Feat: simplify popup by moving rule toggles to options page#171
Merged
Conversation
The popup's per-rule checkbox list has grown too long to be usable as rule count climbed. The popup keeps the enforcement switch, detections, on-page button toggle, and links; rule configuration now lives only on the options page (which already had the same list). Also drops the `disabledByEnforcement` prop from `RuleList` (only the popup ever set it) and the rule-list CSS block from `popup.html`. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
disabledByEnforcementprop fromRuleList(only the popup ever set it) and the now-unused rule-list CSS frompopup.htmlThe popup keeps the enforcement switch, detections, on-page options-button toggle, and footer links.
Test plan
bun run typecheckbun run check(biome + eslint)bun run knipbun run test(1354 tests pass)🤖 Generated with Claude Code