Makes val lazy to prevent circular dependency on DI #10591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@Mergifyio backport master |
Contributor
|
Command
|
Member
Author
|
@Mergifyio backport 2.7.x |
Contributor
|
Command
|
Contributor
|
Command
|
Contributor
|
Command
|
ennru
added a commit
that referenced
this pull request
Dec 11, 2020
Makes val lazy to prevent circular dependency on DI (bp #10591)
mergify bot
added a commit
that referenced
this pull request
Jan 12, 2021
Makes val lazy to prevent circular dependency on DI (bp #10591)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding
defaultFormBinding: FormBindingas avalwe introduced a circular dependency on DI for users ofInjectedController(which is discouraged).The problem becomes more apparent because webjars-play provides some tools which use
InjectedController.See https://travis-ci.com/github/playframework/play-samples/jobs/457151496
Note this issue affects both Java and Scala users as long as there's an intermediate piece on the DI cake that uses
InjectedControllerand even if there's not use of forms.This fixes a regression introduced in Play
2.8.6and2.7.8.