Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Makes val lazy to prevent circular dependency on DI (bp #10591) #10593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mergify merged 2 commits into from
Jan 12, 2021
Merged

Makes val lazy to prevent circular dependency on DI (bp #10591) #10593

mergify merged 2 commits into from
Jan 12, 2021

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Dec 10, 2020

This is an automated backport of pull request #10591 done by Mergify

Cherry-pick of ed4897a has failed:

On branch mergify/bp/master/pr-10591
Your branch is up to date with 'origin/master'.

You are currently cherry-picking commit ed4897abd6.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)

	both modified:   core/play/src/main/scala/play/api/mvc/Controller.scala

no changes added to commit (use "git add" and/or "git commit -a")

To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/

@mergify mergify bot added the conflicts label Dec 10, 2020
@mergify mergify bot mentioned this pull request Dec 10, 2020
Merged
@ignasi35
Makes val lazy to ease DI gods
46e82ee 
(cherry picked from commit ed4897a)
@ignasi35 ignasi35 force-pushed the mergify/bp/master/pr-10591 branch from 40bed91 to 46e82ee Compare December 10, 2020 16:25
@mkurz
Copy link
Member

mkurz commented Jan 11, 2021 •
edited
Loading

@ignasi35 This pull request actually depends on #10582 getting merged first.

@ignasi35
Copy link
Member

ignasi35 commented Jan 12, 2021

@mkurz thanks for the ping!

@ignasi35 ignasi35 closed this Jan 12, 2021
@ignasi35 ignasi35 reopened this Jan 12, 2021
@mergify mergify bot merged commit 31c88df into master Jan 12, 2021
@mergify mergify bot deleted the mergify/bp/master/pr-10591 branch January 12, 2021 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mkurz mkurz mkurz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mkurz @ignasi35