Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Generate and set the request-id as early as possible #13409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mkurz merged 2 commits into from
Jul 16, 2025
Merged

Generate and set the request-id as early as possible #13409

mkurz merged 2 commits into from
Jul 16, 2025

Conversation

@mkurz
Copy link
Member

@mkurz mkurz commented Jul 14, 2025 •
edited
Loading

Improvement thanks to

Makes sure that calling attrs(RequestAttrKey.Id) always returns an id, even if the request was rejected by the server backend (before Play parses any headers to set the cookies, etc.)

playframework/core/play/src/main/scala/play/api/mvc/RequestHeader.scala

Line 40 in 6a4473c

final def id: Long = attrs(RequestAttrKey.Id)

Also in the light of

it makes a lot of sense to generate and set the request id as early as possible as #13204 will include a timestamp in the id.

@mkurz mkurz mentioned this pull request Jul 14, 2025
Draft
@mkurz mkurz force-pushed the request-id_earliest branch 4 times, most recently from e3a9ae1 to 56b0360 Compare July 15, 2025 22:51
@mkurz mkurz force-pushed the request-id_earliest branch from 56b0360 to 1d3ec77 Compare July 15, 2025 23:27
@mkurz
Copy link
Member Author

mkurz commented Jul 16, 2025 •
edited
Loading

As expected the tests I added in first commit failed - and got fixed by the second commit:

[info] PekkoHttpBadClientHandlingSpec
[info] Play should
...
[error]   x allow accessing the raw unparsed path and request-id from an error handler (59 ms)
[error]    500 != 400 (BadClientHandlingSpec.scala:86)
[info] Total for specification PekkoHttpBadClientHandlingSpec
[info] Finished in 21 ms
[info] 4 examples, 1 failure, 0 error

[info] RequestHeaderSpec
[info] request header should
....
[info]   have request id
...
[error]     x not generated if one exists in the attrs already (4 ms)
[error]      85 != 987656789 (RequestHeaderSpec.scala:220)
[info] Total for specification RequestHeaderSpec
[info] Finished in 97 ms
[info] 32 examples, 1 failure, 0 error

It's totally fine to backport as well because default behaviour does not change IMHO.

@mkurz mkurz marked this pull request as ready for review July 16, 2025 10:21
@mkurz mkurz merged commit 702da35 into playframework:main Jul 16, 2025
29 checks passed
@mkurz
Copy link
Member Author

mkurz commented Jul 16, 2025

@Mergifyio backport 2.9.x 3.0.x

@mkurz mkurz deleted the request-id_earliest branch July 16, 2025 10:22
@mergify
Copy link
Contributor

mergify bot commented Jul 16, 2025 •
edited
Loading

backport 2.9.x 3.0.x

✅ Backports have been created

Details

This was referenced Jul 16, 2025
Merged
Merged
mergify bot added a commit that referenced this pull request Jul 16, 2025
@mergify
Merge pull request #13423 from playframework/mergify/bp/3.0.x/pr-13409
7d36c9f 
[3.0.x] Generate and set the request-id as early as possible (backport #13409) by @mkurz
mergify bot added a commit that referenced this pull request Jul 16, 2025
@mergify
Merge pull request #13422 from playframework/mergify/bp/2.9.x/pr-13409
85db056 
[2.9.x] Generate and set the request-id as early as possible (backport #13409) by @mkurz
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mkurz