[2.9.x] Generate and set the request-id as early as possible (backport #13409) by @mkurz #13422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 1d3ec77)
This comment was marked as resolved.
This comment was marked as resolved.
(cherry picked from commit f4b9316) # Conflicts: # transport/server/play-netty-server/src/main/scala/play/core/server/netty/NettyModelConversion.scala
b9a9db5 to
94093e9
Compare
mkurz
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvement thanks to
Makes sure that calling
attrs(RequestAttrKey.Id)always returns an id, even if the request was rejected by the server backend (before Play parses any headers to set the cookies, etc.)playframework/core/play/src/main/scala/play/api/mvc/RequestHeader.scala
Line 40 in 6a4473c
Also in the light of
it makes a lot of sense to generate and set the request id as early as possible as #13204 will include a timestamp in the id.
This is an automatic backport of pull request #13409 done by [Mergify](https://mergify.com).