GH-7105: Remove Play icons from default pages #8213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcospereira
approved these changes
Feb 14, 2018
Member
marcospereira
left a comment
There was a problem hiding this comment.
LGTM.
Thank you, @tkopczynski.
marcospereira
pushed a commit
that referenced
this pull request
Feb 14, 2018
Member
|
Backport to 2.6.x: aac1d3c |
Contributor
|
I understand why this was removed from production templates, but can you please put the favicon back into devError.scala.html asap. Without it, chrome tries a /favicon.ico to fetch it from the server when the error page is loaded triggering another recompile hit to all developers using chrome. |
Member
|
Thanks for the additional information, @Enalmada. Do you want to submit a new PR to re-add the icon? |
Contributor
|
@marcospereira I added #8452 which just adds it back to devError. There is a devNotFound template too but I didn't bother. If you think it needs to be there let me know...I figure devNotFound is all that really matters. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed all Play icons references from defaultpages HTML.
Fixes #7105