Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update documentation links #8648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ignasi35 merged 3 commits into from
Oct 3, 2018
Merged

Update documentation links #8648

ignasi35 merged 3 commits into from
Oct 3, 2018

Conversation

@marcospereira
Copy link
Member

@marcospereira marcospereira commented Oct 2, 2018

Purpose

Correct, update and remove some documentation links.

@ignasi35
Copy link
Member

ignasi35 commented Oct 2, 2018

Uh, oh! The docs validation failed:


SLF4J: Actual binding is of type [org.slf4j.impl.SimpleLoggerFactory]
[error] Could not find resource manual/hacking/images/TravisCI-Full-Color.png at /home/travis/build/playframework/playframework/documentation/manual/hacking/ThirdPartyTools.md:8
[error] [[images/TravisCI-Full-Color.png]]
[error]   ^
java.lang.RuntimeException: Documentation validation failed
	at com.typesafe.play.docs.sbtplugin.PlayDocsValidation$$anonfun$16.apply(PlayDocsValidation.scala:451)
	at com.typesafe.play.docs.sbtplugin.PlayDocsValidation$$anonfun$16.apply(PlayDocsValidation.scala:324)

@marcospereira
Copy link
Member Author

marcospereira commented Oct 2, 2018

@ignasi35 adding the image. :-)

@ignasi35 ignasi35 merged commit cd56580 into playframework:master Oct 3, 2018
This was referenced Oct 3, 2018
Closed
Merged
@ignasi35
Copy link
Member

ignasi35 commented Oct 3, 2018

This didn't backport cleanly so I created a separate PR: #8653

octonato pushed a commit that referenced this pull request Oct 3, 2018
@ignasi35 @octonato
Backports cd56580 from master (#8653)
13fa21c 
#8648 didn't backport cleanly.

There were 2 types of problems:

1. edits on missing files (migration27.md, etc...)
2. CONFLICTs on `javaForms` wrt validation versions (JSR-303 or JSR-380). I preferred the wording from the `2.6.x` branch which still uses `hibernate-validator % 5.4.1.Final`.
@marcospereira marcospereira deleted the validate-external-links branch October 3, 2018 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@PromanSEW PromanSEW PromanSEW left review comments

@ignasi35 ignasi35 ignasi35 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status:to-review topic:documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@marcospereira @ignasi35 @PromanSEW @octonato