Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Backports cd56580 from master #8653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
octonato merged 1 commit into from
Oct 3, 2018
Merged

Backports cd56580 from master #8653

octonato merged 1 commit into from
Oct 3, 2018

Conversation

@ignasi35
Copy link
Member

@ignasi35 ignasi35 commented Oct 3, 2018

#8648 didn't backport cleanly.

There were 2 types of problems:

  1. edits on missing files (migration27.md, etc...)
  2. CONFLICTs on javaForms wrt validation versions (JSR-303 or JSR-380). I preferred the wording from the 2.6.x branch which still uses hibernate-validator % 5.4.1.Final.

@ignasi35 ignasi35 requested a review from marcospereira October 3, 2018 11:07
@ignasi35 ignasi35 mentioned this pull request Oct 3, 2018
Merged
@ignasi35 ignasi35 self-assigned this Oct 3, 2018
@octonato octonato merged commit 13fa21c into playframework:2.6.x Oct 3, 2018
@marcospereira marcospereira added this to the Play 2.6.20 milestone Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcospereira marcospereira Awaiting requested review from marcospereira

1 more reviewer

@octonato octonato octonato approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ignasi35 ignasi35

Labels

status:to-review

Projects

None yet

Milestone

Play 2.6.20

Development

Successfully merging this pull request may close these issues.

3 participants

@ignasi35 @octonato @marcospereira