Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update python layout images doc #1032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 30, 2018

Conversation

michaelbabyn
Copy link
Contributor

I added an example showing how to zoom on a background image without distorting it and got rid of the deprecation warnings.

@priyatharsan
Copy link
Contributor

Great job on the doc. Looks good, except in the "Facial Recognition Overlay" example, the image is not zooming along with the rectangles.

@cldougl cldougl added the ReviewReady This PR is ready for review label Aug 24, 2018
@bcdunbar
Copy link
Contributor

This looks great. As far as this PR goes 💃

That said, some suggestions to make this doc 👌 (not necessarily apart of this PR but probably easy to add on to this)

import plotly.plotly as py
import plotly.tools as tls

import matplotlib.pyplot as plt
import numpy as np
  • The Interactive Facial Recognition Overlays is great but it may be easier to read the example if the code is laid out like the previous examples.

@bcdunbar bcdunbar self-requested a review August 30, 2018 05:44
Copy link
Contributor

@bcdunbar bcdunbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 💃

@michaelbabyn michaelbabyn merged commit 77547b9 into source-design-merge Aug 30, 2018
@archmoj archmoj deleted the update_python_layout_images_doc branch October 13, 2019 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ReviewReady This PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants