HTML to ipynb for bubble, bar, area, box, error bar and quiver-plots #1048

priyatharsan · 2018-08-23T15:55:48Z

Update for bubble, bar, area, box, error bar & quiver-plots #802

jdamiba · 2018-08-23T23:26:12Z

LGTM

bcdunbar

I've left a few comments on the html files (as it is easier to read) but the publisher cells for those files will need updated.

bcdunbar · 2018-08-24T01:12:55Z

_posts/matplotlib/bubble/2015-06-30-bubble.html

+layout: user-guide
+language: matplotlib
+title: Bubble Charts | Plotly
+display_as: chart_type


bcdunbar · 2018-08-24T01:14:33Z

_posts/matplotlib/bubble/2015-06-30-bubble.html

@@ -0,0 +1,267 @@
+---
+permalink: matplotlib/bubble-charts/
+description: How to make your-tutorial-chart plots in Python with Plotly.


Somthing like: "How to make bubble charts in matplotlib."

bcdunbar · 2018-08-24T01:16:59Z

_posts/matplotlib/quiver-plots/2015-06-30-quiver_plots.html

@@ -0,0 +1,218 @@
+---
+permalink: python/your-tutorial-chart/


missing URL

…nk url to quiver plot

jdamiba · 2018-08-24T01:30:30Z

I made the edits requested by @bcdunbar.

priyatharsan · 2018-08-24T02:21:25Z

thanks! 👍

cldougl · 2018-08-24T12:03:48Z

_config_dev.yml

-# all of the posts:  ['*.Rmd','_posts/2015-09-09-matlab-reference.html','_posts/2015-09-06-r-reference.html','_posts/2015-09-06-python-reference.html','_posts/2015-08-19-plotly_js-reference.html','_posts/2015-04-05-ggplot2-index.html','_posts/2015-04-05-julia-index.html','_posts/2015-04-05-matlab-index.html','_posts/2015-04-05-matplotlib-index.html','_posts/2015-04-05-node_js-index.html','_posts/2015-04-05-plotly_js-index.html','_posts/2015-04-05-plotlyjs-function-reference.md','_posts/2015-04-05-python-index.html','_posts/2015-05-25-ipython-notebooks_gallery.html','_posts/2015-05-25-ipython-notebooks_index.html','_posts/2015-07-13-eula_index.html','_posts/2015-07-19-pandas.html','_posts/2015-07-26-index.html','_posts/2015-07-30-r-index.Rmd','_posts/2015-07-30-r-index.md','_posts/2015-08-20-research-box-index.html','_posts/ggplot2','_posts/julia','_posts/matlab','_posts/matplotlib','_posts/nodejs','_posts/pandas','_posts/plotly_js','_posts/python','_posts/r','_posts/tutorials','_posts/user_guide_matlab','_posts/user_guide_python']
-exclude:  ['*.Rmd','_posts/matlab','_posts/dashboards','_posts/julia','_posts/matplotlib','_posts/misc','_posts/nodejs','_posts/numpy','_posts/scala','_posts/scikit','_posts/tutorials','_posts/user_guide_matlab','_posts/user_guide_python']
+exclude:  ['*.Rmd','_posts/2015-09-09-matlab-reference.html','_posts/2015-09-06-r-reference.html','_posts/2015-08-19-plotly_js-reference.html','_posts/2015-04-05-ggplot2-index.html','_posts/2015-04-05-julia-index.html','_posts/2015-04-05-matlab-index.html','_posts/2015-04-05-matplotlib-index.html','_posts/2015-04-05-node_js-index.html','_posts/2015-04-05-plotly_js-index.html','_posts/2015-04-05-plotlyjs-function-reference.md','_posts/2015-04-05-python-index.html','_posts/2015-05-25-ipython-notebooks_gallery.html','_posts/2015-05-25-ipython-notebooks_index.html','_posts/2015-07-13-eula_index.html','_posts/2015-07-19-pandas.html','_posts/2015-07-26-index.html','_posts/2015-07-30-r-index.Rmd','_posts/2015-07-30-r-index.md','_posts/2015-08-20-research-box-index.html','_posts/ggplot2','_posts/julia','_posts/matlab','_posts/nodejs','_posts/pandas','_posts/plotly_js','_posts/r','_posts/tutorials','_posts/user_guide_matlab','_posts/user_guide_python']
+# exclude:  ['*.Rmd','_posts/matlab','_posts/dashboards','_posts/julia','_posts/misc','_posts/nodejs','_posts/numpy','_posts/scala','_posts/scikit','_posts/tutorials','_posts/user_guide_matlab','_posts/user_guide_python']


I'd recommend not committing this change
we definitely want to keep the # all of the posts: line there so we have a reference of all options. Editing the excluded list doesn't matter so much for the dev config, but the all posts line should not be removed

I guess it could be from @jdamiba's last commit. I will revert the commit and make all necessary changes

cldougl · 2018-08-24T12:10:38Z

_posts/matplotlib/bubble/bubble.ipynb

+   "cell_type": "markdown",
+   "metadata": {},
+   "source": [
+    "#### Bubble chart with scatter marker size\n",


🐐 please capitalize titles

cldougl · 2018-08-24T12:11:50Z

_posts/matplotlib/bubble/bubble.ipynb

+   "cell_type": "markdown",
+   "metadata": {},
+   "source": [
+    "#### Matplotlib Bubble Chart using Colormap (`cmap`)"


🐐 consistent capitalization (**** code words do not need to be capitalized but using should be)

cldougl · 2018-08-24T12:14:03Z

_posts/matplotlib/bubble/bubble.ipynb

+    }
+   ],
+   "source": [
+    "import matplotlib.pyplot as plt\n",


best practice is to keep import order consistent and import plotly packages first then a space then additional packages like:

import plotly.plotly as py import plotly.tools as tls import matplotlib.pyplot as plt import numpy as np

cldougl · 2018-08-24T12:17:04Z

_posts/matplotlib/area/matplotlib_area.ipynb

+   "cell_type": "markdown",
+   "metadata": {},
+   "source": [
+    "#### Matplotlib Area Plot"


typically we want the examples to be in order from most basic -> most advanced on the page. This seems like the most basic example so I suggest moving this first.

… permalink url to quiver plot" This reverts commit e7d739d.

priyatharsan · 2018-08-24T20:35:50Z

made all necessary changes @cldougl @bcdunbar

bcdunbar · 2018-08-27T09:38:34Z

@priyatharsan You'll want to do #1048 (comment) in all the notebooks. Also, ensure that it is the same way @cldougl had it i.e. "plotly packages first then a space then additional packages "

bcdunbar · 2018-08-27T09:48:29Z

_posts/matplotlib/area/matplotlib_area.ipynb

+    "import plotly.tools as tls\n",
+    "\n",
+    "# Learn about API authentication here: https://plot.ly/python/getting-started\n",
+    "# Find your api_key here: https://plot.ly/settings/api\n",


# Learn about API authentication here: https://plot.ly/python/getting-started # Find your api_key here: https://plot.ly/settings/api

Looking at it again, I don't think that we require these commented lines anymore. They seem redundant given that this information is contained in the New to Plotly? section.

bcdunbar · 2018-08-29T03:13:26Z

import order and other changes look good 👍

One last suggestion: update the reference section to point to the reference page https://plot.ly/python/reference/

bcdunbar

lgtm 💃

Thanks for making all the changes 👍

HTML to ipynb for bubble, bar, area, box, error bar

af8454f

priyatharsan requested a review from bcdunbar August 23, 2018 15:56

priyatharsan added the ReviewReady This PR is ready for review label Aug 23, 2018

added quiver-plots update

4160d0f

priyatharsan changed the title ~~HTML to ipynb for bubble, bar, area, box, error bar~~ HTML to ipynb for bubble, bar, area, box, error bar and quiver-plots Aug 23, 2018

bcdunbar suggested changes Aug 24, 2018

View reviewed changes

changed bubble chart type to basic, edited description, added permali…

e7d739d

…nk url to quiver plot

cldougl requested changes Aug 24, 2018

View reviewed changes

cldougl removed the ReviewReady This PR is ready for review label Aug 24, 2018

priyatharsan added 2 commits August 24, 2018 16:06

Revert "changed bubble chart type to basic, edited description, added…

a08d04c

… permalink url to quiver plot" This reverts commit e7d739d.

updated the titles, import orders and other reviewed changes

4a536a8

bcdunbar reviewed Aug 27, 2018

View reviewed changes

This was referenced Aug 27, 2018

HTML to ipynb for histograms and heatmaps #1049

Merged

HTML to ipynb update for scatter and line charts #1047

Merged

Update python layout images doc #1032

Merged

updated import order and removed the commented texts

cca2025

reference update

9d83fdc

bcdunbar approved these changes Aug 30, 2018

View reviewed changes

priyatharsan merged commit 8799c18 into source-design-merge Aug 30, 2018

priyatharsan deleted the matplotlib-doc-update branch August 30, 2018 14:19

Uh oh!

HTML to ipynb for bubble, bar, area, box, error bar and quiver-plots #1048

HTML to ipynb for bubble, bar, area, box, error bar and quiver-plots #1048

Uh oh!

Conversation

priyatharsan commented Aug 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jdamiba commented Aug 23, 2018 • edited by cldougl Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bcdunbar left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jdamiba commented Aug 24, 2018

Uh oh!

priyatharsan commented Aug 24, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

priyatharsan commented Aug 24, 2018

Uh oh!

bcdunbar commented Aug 27, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bcdunbar commented Aug 29, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bcdunbar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

priyatharsan commented Aug 23, 2018 •

edited

Loading

jdamiba commented Aug 23, 2018 •

edited by cldougl

Loading

bcdunbar commented Aug 29, 2018 •

edited

Loading