Thanks to visit codestin.com
Credit goes to github.com

Skip to content

HTML to ipynb update for scatter and line charts #1047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

priyatharsan
Copy link
Contributor

Update for scatter, line charts and line and scatter #802

@priyatharsan priyatharsan added the ReviewReady This PR is ready for review label Aug 22, 2018
Copy link
Contributor

@bcdunbar bcdunbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to comment inline but I think it will be easier to write here (I put a couple in there).

I think it would be worthwhile consolidating all 4 of the Matplotlib docs into 2 docs that would align more with the native Plotly docs.

Thus,
https://plot.ly/matplotlib/lines-and-markers/
https://plot.ly/matplotlib/scatter/
https://plot.ly/matplotlib/plot/
https://plot.ly/matplotlib/line-and-scatter/

To,
Scatter Plots https://plot.ly/matplotlib/line-and-scatter/
Line Charts https://plot.ly/matplotlib/line-charts/

That way the URLs are the same and the Matplotlib docs are linked with the native Plotly.

Unless the Matplotlib URLs are like that for searching purposes @cldougl ? Though I don't think it would be.

@@ -0,0 +1,292 @@
---
permalink: matplotlib/line-and-scatter/
description: How to make line and scatter plots in matplotlib. Seven examples of basic and colored line and scatter plots.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove this Seven examples of basic and colored line and scatter plots.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

layout: user-guide
language: matplotlib
title: Matplotlib Line and Scatter Plots | Plotly
display_as: chart_type
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

basic?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops yeah. supposed to be basic

@cldougl
Copy link
Member

cldougl commented Aug 23, 2018

Unless the Matplotlib URLs are like that for searching purposes @cldougl ? Though I don't think it would be.

We probably are trying to get results from 'matplotlib plot' with https://plot.ly/matplotlib/plot/

For now I would suggest keeping https://plot.ly/matplotlib/plot/ and then consolidating:

https://plot.ly/matplotlib/lines-and-markers/
https://plot.ly/matplotlib/scatter/
https://plot.ly/matplotlib/line-and-scatter/

To:
Scatter Plots https://plot.ly/matplotlib/line-and-scatter/
Line Charts https://plot.ly/matplotlib/line-charts/

and adding redirects for the old urls:

https://plot.ly/matplotlib/lines-and-markers/ --> https://plot.ly/matplotlib/line-charts/
https://plot.ly/matplotlib/scatter/ --> https://plot.ly/matplotlib/line-and-scatter/

how does that sound @bcdunbar @priyatharsan ?

@bcdunbar
Copy link
Contributor

Agreed! sg 👍

@priyatharsan
Copy link
Contributor Author

Sg to me as well.

@bcdunbar
Copy link
Contributor

bcdunbar commented Aug 27, 2018

@priyatharsan sweet 👍

Could you sweep through the .ipynbs and ensure that:

@bcdunbar
Copy link
Contributor

Thanks for making the changes.

Same as mentioned in other PRs, update the reference section to point to the reference page https://plot.ly/python/reference/

Copy link
Contributor

@bcdunbar bcdunbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 💃

@priyatharsan priyatharsan merged commit feaab9b into source-design-merge Aug 30, 2018
@priyatharsan priyatharsan deleted the matplotlib-lines-and-scatter-doc-update branch August 30, 2018 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ReviewReady This PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants