Thanks to visit codestin.com
Credit goes to github.com

Skip to content

HTML to ipynb update - matplotlib/backgounds and lines-and-markers #1039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 24, 2018
Merged

HTML to ipynb update - matplotlib/backgounds and lines-and-markers #1039

merged 3 commits into from
Aug 24, 2018

Conversation

priyatharsan
Copy link
Contributor

Update for backgrounds #802

@priyatharsan priyatharsan added the ReviewReady This PR is ready for review label Aug 20, 2018
@priyatharsan
Copy link
Contributor Author

priyatharsan commented Aug 21, 2018 •
edited
Loading

Note this issue: plotly/plotly.py#1123 for lines-and-marker.

I removed ':' linestyles alone for the tutorial. If that works out.

@priyatharsan priyatharsan changed the title HTML to ipynb update - matplotlib/backgounds HTML to ipynb update - matplotlib/backgounds and lines-and-markers Aug 21, 2018
@priyatharsan
Copy link
Contributor Author

priyatharsan commented Aug 23, 2018 •
edited
Loading

reverting 61636eb as changes have been made in this commit 650dd60 for PR #1047

@priyatharsan
Copy link
Contributor Author

@bcdunbar Please note only backgrounds file has been changed in this PR.

@bcdunbar bcdunbar self-requested a review August 24, 2018 01:25
bcdunbar
bcdunbar approved these changes Aug 24, 2018
View reviewed changes
Copy link
Contributor

@bcdunbar bcdunbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@priyatharsan thanks for making the changes 💃

@priyatharsan priyatharsan merged commit 38bc4da into source-design-merge Aug 24, 2018
@priyatharsan priyatharsan deleted the matplotlib-backgrounds-doc-update branch August 24, 2018 02:17
@priyatharsan
Copy link
Contributor Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcdunbar bcdunbar bcdunbar approved these changes

Assignees
No one assigned
Labels
ReviewReady This PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@priyatharsan @bcdunbar