-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
David/enhancement modebar #7429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
So I'm wondering what are the configuration options for the modebar besides hover, and what actually changes the visibility during hover (is it just css? can we do the same thing for focus as hover). Also looks like your editor did a bunch of reformatting, you should undo that Also, if we use button, we don't need tabindex now, right? |
Yeah, so, we have two options:
I prefer 2 but we should do one or the other |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what are the configuration options for the modebar? can we fix the formatting? can we choose one of two accessibility strategies?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also we need to fix the dist/ build/ folders, ill figure out who I should cc
@gvwilson this is an accessibility which makes the modebar tab-able (some of the buttons require a mouse but not all of them). Can someone on your team clarify for us what we need to run to fix the build/ and dist/ folders to submit the PR properly? @davidangarita1, I'd like some help understand the modebar a little better. Do you understand how its configured and what its options are? |
I'm interested in changing the modebar through configuration |
@ayjayt here is the config an options: |
Yeah so let's just make sure no options interfere with the accessibility setup and vice versa |
Pull request to improve accessibility for the modebar