David/enhancement modebar #7429
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So I'm wondering what are the configuration options for the modebar besides hover, and what actually changes the visibility during hover (is it just css? can we do the same thing for focus as hover). Also looks like your editor did a bunch of reformatting, you should undo that Also, if we use button, we don't need tabindex now, right? |
|
Yeah, so, we have two options:
I prefer 2 but we should do one or the other |
ayjayt
suggested changes
Jun 3, 2025
Comment on lines
+33
to
37
| a { | ||
| display: grid; | ||
| place-content: center; | ||
| } | ||
| } |
There was a problem hiding this comment.
This anchor belongs to the plotly logo at the end of the modebar.
Comment on lines
+48
to
+49
| border: none; | ||
| background: transparent; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request to improve accessibility for the modebar