Thanks to visit codestin.com
Credit goes to github.com

Skip to content

David/enhancement modebar #7429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

davidangarita1
Copy link

@davidangarita1 davidangarita1 commented May 28, 2025

Pull request to improve accessibility for the modebar

@ayjayt
Copy link
Contributor

ayjayt commented Jun 3, 2025

So I'm wondering what are the configuration options for the modebar besides hover, and what actually changes the visibility during hover (is it just css? can we do the same thing for focus as hover).

Also looks like your editor did a bunch of reformatting, you should undo that

Also, if we use button, we don't need tabindex now, right?

@ayjayt
Copy link
Contributor

ayjayt commented Jun 3, 2025

Yeah, so, we have two options:

  1. add accessibility manually w/ javascript (tabindex and onevent listener)

  2. just use a button (but care for the styling changes)

I prefer 2 but we should do one or the other

Copy link
Contributor

@ayjayt ayjayt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what are the configuration options for the modebar? can we fix the formatting? can we choose one of two accessibility strategies?

@davidangarita1 davidangarita1 marked this pull request as ready for review June 3, 2025 17:31
Copy link
Contributor

@ayjayt ayjayt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also we need to fix the dist/ build/ folders, ill figure out who I should cc

@ayjayt
Copy link
Contributor

ayjayt commented Jun 3, 2025

@gvwilson this is an accessibility which makes the modebar tab-able (some of the buttons require a mouse but not all of them). Can someone on your team clarify for us what we need to run to fix the build/ and dist/ folders to submit the PR properly?

@davidangarita1, I'd like some help understand the modebar a little better. Do you understand how its configured and what its options are?

@ayjayt
Copy link
Contributor

ayjayt commented Jun 4, 2025

@ayjayt Here I share with you the explanation of the buttons on the mode bar

image

The order of explanation will be from the icon on the left to the one on the right.

Download plot as a PNG: Saves the chart as a PNG image file. Zoom: Click and drag to zoom into a specific area. Pan: Click and drag to move the view of the chart. Box Select: Select data points within a rectangular area. Lasso Select: Select data points within a freeform (lasso) shape. Zoom in: Incrementally zooms in on the plot. Zoom out: Incrementally zooms out of the plot. Autoscale: Automatically fits the data within the plot area. Reset axes: Resets zoom and axis limits to their original state. Plotly logo: Opens the Plotly homepage in a new tab. It doesn’t affect the chart.

I'm interested in changing the modebar through configuration

@davidangarita1
Copy link
Author

@ayjayt here is the config an options:
https://plotly.com/javascript/configuration-options/#force-the-modebar-to-always-be-visible

@ayjayt
Copy link
Contributor

ayjayt commented Jun 4, 2025

Yeah so let's just make sure no options interfere with the accessibility setup and vice versa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants