Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Adding basic meta tags. #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 8, 2018
Merged

Adding basic meta tags. #565

merged 5 commits into from
Mar 8, 2018

Conversation

himanshuc3
Copy link
Contributor

  • MIME type
  • keywords
  • Description

@catarak
Copy link
Member

catarak commented Feb 22, 2018

awesome! in the future, could you open an issue first so that the pull request can reference an issue? also this brings up a good question as to what we want these meta tags to be. thoughts @lmccart & @shiffman?

@shiffman
Copy link
Member

This is great! I might suggest avoiding the word "playground", I like the spirit of that very much, but it might be confusing as there is @yining1023's project which is actually called p5 playground! http://1023.io/p5-inspector/

I think for now: "p5.js", "p5.js web editor", "web editor" are good?

@lmccart
Copy link
Member

lmccart commented Feb 22, 2018

I would also add "processing", "code editor"

@catarak
Copy link
Member

catarak commented Feb 26, 2018

could you change the description from "A web editor for sketching using p5.js library." to "A web editor for p5.js, a JavaScript library with the goal of making coding accessible to artists, designers, educators, and beginners."

@himanshuc3
Copy link
Contributor Author

@catarak
Copy link
Member

catarak commented Feb 27, 2018

could you also add these meta tags to server/views/404page.js? also server/views/mailLayout.js? emails also have meta tags, right?

@himanshuc3
Copy link
Contributor Author

Do you want me add the same or have a discussion about what their description should contain.

@catarak
Copy link
Member

catarak commented Feb 28, 2018

i think they should be the same, thanks!

@himanshuc3
Copy link
Contributor Author

@catarak I added meta tags to 404error page. MailLayout page is made using mjml library and I could not find any existing meta tag support, though basic tags such as IE-edge support, content type are added by default. Adding meta tags to mailLayout could be made using another PR as a custom component could be made for it.

@catarak
Copy link
Member

catarak commented Mar 8, 2018

okay! i can open an issue about it. maybe emails don't need meta tags, but we can investigate it!

@catarak catarak merged commit ae1e13f into processing:master Mar 8, 2018
@catarak catarak mentioned this pull request Mar 8, 2018
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants