Add CI, make tests pass on non-linux #86
Conversation
| @@ -160,6 +161,10 @@ def test_delete_with_groupingkey(self): | |||
| self.assertEqual(self.requests[0][0].headers.get('content-type'), CONTENT_TYPE_LATEST) | |||
| self.assertEqual(self.requests[0][1], b'') | |||
|
|
|||
| @unittest.skipUnless( | |||
| sys.platform.startswith("linux"), | |||
| "instance_ip_grouping_key() only works on linux." | |||
There was a problem hiding this comment.
I think it's only OS X that's broken.
I'd like to test 2.6. That looks to be a mix of a dependency issue, and not having the improved float printing semantics for histogram buckets. Could the first be fixed, and the second excluded from testing? |
|
While I think that 2.6 is terrible and nobody should use it, I would suggest to put it in a separate PR. |
|
r4r btw |
|
CentOS 6 is still supported and provides python 2.6, we have to work with what our users have not what we wish they have. I'd not have separate tests for twisted, there's be various other optional deps over time so that won't scale well. |
|
I’m not sure how your comment relates to my suggestion to put it into a separate PR? |
|
As for the second part, you want to have code paths that are not covered by CI on purpose? How do you want to ensure long-term that stuff doesn’t break? |
|
The code paths would only be not covered on Python 2.6, the chances of them breaking only there is pretty low as that particular piece of code is stable. |
|
Your answer kind of mixes my two questions. :) Let me try again:
|
|
It's ok to have in a separate one. I'm thinking more that a separate run just for twisted might be a bit much, and it should be combined into the main one. |
|
Alright! So I would suggest the following: let twisted be part of regular run but have one Simply because it's really easy to screw up by importing something somewhere with unintended consequences. |
|
Since your main concern was, that the list of optional deps is gonna grow, I ended up calling the env Let me know what you think. |
|
That looks generally fine, can you add a nooptions on 2.7 too so both major versions are covered? |
|
sure; done. |
|
Can you squash your commits please? |
|
Done. I’ve activated Travis for my fork and you can see the latest build here btw: https://travis-ci.org/hynek/client_python/builds/143289122 |
|
Thanks! |
This is mainly to remove friction from contributing.
A couple of notes:
toxpython -m unittestworks differently across python versions. I could also use nose or something but I chose pytest as it’s more familiar to me.Let me know if you have any questions or concerns.