-
Notifications
You must be signed in to change notification settings - Fork 818
add restricted registry documentation #968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: remi <[email protected]>
92c0df2
to
f533910
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
One note, you can also define a restricted registry from code, perhaps document how to do that as well as the name[]
behavior?
Signed-off-by: remi <[email protected]>
1eb884d
to
3c9065c
Compare
Signed-off-by: remi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small suggestions, but generally 👍!
Co-authored-by: Chris Marchbanks <[email protected]> Signed-off-by: Remi Jouannet <[email protected]>
Co-authored-by: Chris Marchbanks <[email protected]> Signed-off-by: Remi Jouannet <[email protected]>
Co-authored-by: Chris Marchbanks <[email protected]> Signed-off-by: Remi Jouannet <[email protected]>
Thanks! |
i found this undocumented feature in the code, it's pretty useful to debug an exporter that return thousand of metrics.
i don't know if having this feature undocumented was intentional or not
(@csmarchbanks)