add restricted registry documentation #968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: remi <[email protected]>
92c0df2 to
f533910
Compare
Member
csmarchbanks
left a comment
There was a problem hiding this comment.
Thanks!
One note, you can also define a restricted registry from code, perhaps document how to do that as well as the name[] behavior?
Signed-off-by: remi <[email protected]>
1eb884d to
3c9065c
Compare
Signed-off-by: remi <[email protected]>
Member
csmarchbanks
left a comment
There was a problem hiding this comment.
A few small suggestions, but generally 👍!
Co-authored-by: Chris Marchbanks <[email protected]> Signed-off-by: Remi Jouannet <[email protected]>
Co-authored-by: Chris Marchbanks <[email protected]> Signed-off-by: Remi Jouannet <[email protected]>
Co-authored-by: Chris Marchbanks <[email protected]> Signed-off-by: Remi Jouannet <[email protected]>
csmarchbanks
approved these changes
Oct 24, 2023
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i found this undocumented feature in the code, it's pretty useful to debug an exporter that return thousand of metrics.
i don't know if having this feature undocumented was intentional or not
(@csmarchbanks)