I think I made a mistake when i glanced at the code earlier. That's what i get when i do things in a rush.

Python 3.12.4 has this commit:

vfazio@Zephyrus:~/development/cpython$ git describe --contains 5430f614371530aab1178b3b610add4bf54c383e
v3.12.4~194

Which is: python/cpython#118104

Which changed the function signature of ForwardRef._evaluate to force recursive_guard to be a kwarg

def _evaluate(self, globalns, localns, type_params=None, *, recursive_guard):

>>> inspect.signature(typing.ForwardRef._evaluate).parameters['recursive_guard'].kind
<_ParameterKind.KEYWORD_ONLY: 3>

The fixup should maybe be:

if sys.version_info < (3, 9):

    def evaluate_forwardref(type_: ForwardRef, globalns: Any, localns: Any) -> Any:
        return type_._evaluate(globalns, localns)

else:
    def evaluate_forwardref(type_: ForwardRef, globalns: Any, localns: Any) -> Any:
        # Even though it is the right signature for python 3.9, mypy complains with
        # `error: Too many arguments for "_evaluate" of "ForwardRef"` hence the cast...
        # Note 3.13/3.12.4+ made `recursive_guard` a kwarg, so name it explicitly to avoid:
        # TypeError: ForwardRef._evaluate() missing 1 required keyword-only argument: 'recursive_guard'
        return cast(Any, type_)._evaluate(globalns, localns, recursive_guard=set())

The syntax should work on previous versions (pre 3.12.4/3.13) and also work for the new kwarg status.

The extra set() is unnecessary and is actually overwriting the default value for type_params.

Anyway, totally untested, but my thoughts. I am not a maintainer, so this should also be taken with a modest amount of skepticism

I think I made a mistake when i glanced at the code earlier. That's what i get when i do things in a rush.

Python 3.12.4 has this commit:

vfazio@Zephyrus:~/development/cpython$ git describe --contains 5430f614371530aab1178b3b610add4bf54c383e
v3.12.4~194

Which is: python/cpython#118104

Which changed the function signature of ForwardRef._evaluate to force recursive_guard to be a kwarg

def _evaluate(self, globalns, localns, type_params=None, *, recursive_guard):

>>> inspect.signature(typing.ForwardRef._evaluate).parameters['recursive_guard'].kind
<_ParameterKind.KEYWORD_ONLY: 3>

The fixup should maybe be:

if sys.version_info < (3, 9):

    def evaluate_forwardref(type_: ForwardRef, globalns: Any, localns: Any) -> Any:
        return type_._evaluate(globalns, localns)

else:
    def evaluate_forwardref(type_: ForwardRef, globalns: Any, localns: Any) -> Any:
        # Even though it is the right signature for python 3.9, mypy complains with
        # `error: Too many arguments for "_evaluate" of "ForwardRef"` hence the cast...
        # Note 3.13/3.12.4+ made `recursive_guard` a kwarg, so name it explicitly to avoid:
        # TypeError: ForwardRef._evaluate() missing 1 required keyword-only argument: 'recursive_guard'
        return cast(Any, type_)._evaluate(globalns, localns, recursive_guard=set())

The syntax should work on previous versions (pre 3.12.4/3.13) and also work for the new kwarg status.

The extra set() is unnecessary and is actually overwriting the default value for type_params.

Anyway, totally untested, but my thoughts

Is it just that I need to run tests on all python versions to make sure it's correct? Can you guide me, because I really want to fix this error, thank you.