Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix missing recursive_guard parameter in Pydantic v1 for python 3.12.4+ #9611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Fix missing recursive_guard parameter in Pydantic v1 for python 3.12.4+ #9611

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4964bcd
fix (typing): Add params abc recursive_guard in pydantic v1 for pytho…
ellyx13 Jun 8, 2024
4dd82bc
Fix missing recursive_guard parameter in Pydantic v1 for Python 3.9 t…
ellyx13 Jun 8, 2024
19c128e
Fix missing recursive_guard parameter in Pydantic v1 for 3.12.4+
ellyx13 Jun 8, 2024
59c770c
Fix lint failure in CI
ellyx13 Jun 8, 2024
68458d0
Attempt sugested fix
sydney-runkle Jun 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pydantic/v1/typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,16 +54,16 @@


if sys.version_info < (3, 9):

def evaluate_forwardref(type_: ForwardRef, globalns: Any, localns: Any) -> Any:
return type_._evaluate(globalns, localns)

else:

def evaluate_forwardref(type_: ForwardRef, globalns: Any, localns: Any) -> Any:
# Even though it is the right signature for python 3.9, mypy complains with
# `error: Too many arguments for "_evaluate" of "ForwardRef"` hence the cast...
return cast(Any, type_)._evaluate(globalns, localns, set())
# Note 3.13/3.12.4+ made `recursive_guard` a kwarg, so name it explicitly to avoid:
# TypeError: ForwardRef._evaluate() missing 1 required keyword-only argument: 'recursive_guard'
return cast(Any, type_)._evaluate(globalns, localns, recursive_guard=set())


if sys.version_info < (3, 9):
Expand Down