Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix case sensitivity of entry point names and keys in setup.cfg. Fixes #1937 #2580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaraco merged 6 commits into from
Feb 25, 2021
Merged

Fix case sensitivity of entry point names and keys in setup.cfg. Fixes #1937 #2580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
21b122e
Preserve case-sensitive keys in setup.cfg
melissa-kun-li Feb 24, 2021
90d8740
Add case-sensitive entry point name test
melissa-kun-li Feb 24, 2021
3965904
Add change note
melissa-kun-li Feb 24, 2021
7f3e6d6
Update test for case-sensitive entry point names
melissa-kun-li Feb 25, 2021
11529db
Update change log
melissa-kun-li Feb 25, 2021
898a0b5
Remove 'breaking' changelog, superseded by 'change'.
jaraco Feb 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/1937.change.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Preserved case-sensitivity of keys in setup.cfg so that entry point names are case-sensitive. Changed sensitivity of configparser. NOTE: Any projects relying on case-insensitivity will need to adapt to accept the original case as published. -- by :user:`melissa-kun-li`
1 change: 1 addition & 0 deletions setuptools/dist.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -583,6 +583,7 @@ def _parse_config_files(self, filenames=None): # noqa: C901
self.announce("Distribution.parse_config_files():")

parser = ConfigParser()
parser.optionxform = str
for filename in filenames:
with io.open(filename, encoding='utf-8') as reader:
if DEBUG:
Expand Down
18 changes: 18 additions & 0 deletions setuptools/tests/test_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -802,6 +802,24 @@ def test_entry_points(self, tmpdir):
with get_dist(tmpdir) as dist:
assert dist.entry_points == expected

def test_case_sensitive_entry_points(self, tmpdir):
_, config = fake_env(
tmpdir,
'[options.entry_points]\n'
'GROUP1 = point1 = pack.module:func, '
'.point2 = pack.module2:func_rest [rest]\n'
'group2 = point3 = pack.module:func2\n'
)

with get_dist(tmpdir) as dist:
assert dist.entry_points == {
'GROUP1': [
'point1 = pack.module:func',
'.point2 = pack.module2:func_rest [rest]',
],
'group2': ['point3 = pack.module:func2']
}

def test_data_files(self, tmpdir):
fake_env(
tmpdir,
Expand Down