Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix case sensitivity of entry point names and keys in setup.cfg. Fixes #1937#2580

Merged
jaraco merged 6 commits into
pypa:mainfrom
melissa-kun-li:fix-entry-points-name-case-sensitivity
Feb 25, 2021
Merged

Fix case sensitivity of entry point names and keys in setup.cfg. Fixes #1937#2580
jaraco merged 6 commits into
pypa:mainfrom
melissa-kun-li:fix-entry-points-name-case-sensitivity

Conversation

@melissa-kun-li

@melissa-kun-li melissa-kun-li commented Feb 24, 2021

Copy link
Copy Markdown
Contributor

Summary of changes

Closes #1937

To address the bug of entry point names being made lower-case by Setuptools, this fix preserves case-sensitivity of keys in setup.cfg by changingConfigParser to become case-sensitive. Edit: by extension this will also address any issues about keys in setup.cfg not retaining case-sensitivity such as in #2480

Pull Request Checklist

@melissa-kun-li melissa-kun-li changed the title Fix entry points name case sensitivity and change key sensitivity in setup.cfg Fix case sensitivity of entry point names and keys in setup.cfg. Fixes #1937 Feb 24, 2021

@jaraco jaraco left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Looks like a simple change, but I know it involved a great deal of work to figure it out. This change will help a lot of people. One small request above then it's good to go.

Comment thread setuptools/tests/test_config.py Outdated
Comment thread changelog.d/1937.breaking.rst Outdated
@jaraco jaraco merged commit 72c7a6c into pypa:main Feb 25, 2021
@jaraco

jaraco commented Feb 25, 2021

Copy link
Copy Markdown
Member

Releasing as 53.1.0. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

setup.cfg: entry_points keys are made lowercase

2 participants