Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Warn for uppercase key usage in metadata in setup.cfg, provides compatibility. Fixes #2592#2593

Merged
jaraco merged 5 commits into
pypa:mainfrom
melissa-kun-li:uppercase_metadata_warning
Mar 7, 2021
Merged

Warn for uppercase key usage in metadata in setup.cfg, provides compatibility. Fixes #2592#2593
jaraco merged 5 commits into
pypa:mainfrom
melissa-kun-li:uppercase_metadata_warning

Conversation

@melissa-kun-li

@melissa-kun-li melissa-kun-li commented Mar 6, 2021

Copy link
Copy Markdown
Contributor

Summary of changes

Closes #2592

This will warn users if they use an uppercase key in metadata in setup.cfg. This will also convert any uppercase keys in metadata to lowercase to restore some compatibility due to the change by #2580 in which keys in setup.cfg became case-sensitive.

Pull Request Checklist

@melissa-kun-li melissa-kun-li changed the title Uppercase metadata warning Warn for uppercase key usage in metadata in setup.cfg, provides compatibility. Fixes #2592 Mar 6, 2021
Comment thread setuptools/dist.py Outdated
Comment thread setuptools/tests/test_config.py Outdated
Comment thread setuptools/dist.py Outdated
Comment thread setuptools/dist.py Outdated
Comment thread changelog.d/2592.change.rst Outdated
Comment thread setuptools/dist.py Outdated
@jaraco jaraco force-pushed the uppercase_metadata_warning branch from 2d6453e to 66323ad Compare March 7, 2021 02:56
@jaraco

jaraco commented Mar 7, 2021

Copy link
Copy Markdown
Member

Thanks Melissa for the follow up and quick response. Thanks Sviatoslav for the edits.

@jaraco jaraco merged commit 15249f1 into pypa:main Mar 7, 2021
@melissa-kun-li

Copy link
Copy Markdown
Contributor Author

Thank you @webknjaz and @jaraco for the code review/edits and explanations! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Name" metadata keyword not recognized

3 participants