Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

jklenzing
Copy link
Member

Description

Updates GA environment to be compatible with latest environments. Updates to pip usage for RC installs.

Version cap on hacking until E275 is cleaned up in code.

Updates pandas syntax removed in 2.0.0 (is_monotonic and close kwarg).

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

via pytest with pandas 2.0.0 installed.

Test Configuration:

  • Operating system: Ventura
  • Version number: Python 3.10.8
  • pandas 2.0.1

Checklist:

  • Make sure you are merging into the develop (not main) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes

If this is a release PR, replace the first item of the above checklist with the
release checklist on the pysat wiki:
https://github.com/pysat/pysat/wiki/Checklist-for-Release

@jklenzing
Copy link
Member Author

Partial update to nose syntax issues while debugging the pandas updates. Documented in #127

@jklenzing
Copy link
Member Author

Not sure what's going on in the doc tests

@jklenzing jklenzing requested a review from aburrell May 1, 2023 19:29
- start).days != len(inst.files[start:stop]):
missing_times = [tt for tt in pds.date_range(start, stop, freq='1D',
closed='left')
inclusive='left')
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

closed was deprecated in pandas 1.4.0 and removed in 2.0+


# Confirm time index information
assert data_two_days.indexes['time'].is_monotonic
assert data_two_days.indexes['time'].is_monotonic_increasing
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is_monotonic deprecated in pandas 1.5.0 and removed in 2.0+

fail-fast: false
matrix:
os: ["ubuntu-latest", "macos-latest", "windows-latest"]
python-version: ["3.10"] # Keep this version at the highest supported Python version
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought for the future: have this do the highest and lowest versions.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could probably do all supported versions since this test is quick.

@jklenzing
Copy link
Member Author

Not sure what's going on in the doc tests

See pysat/pysat#1120. New error related to Sphinx 7.0.0. Not sure what the root cause is yet. Apparently the 'style' key has been removed in this version, but I don't see where we invoke this in conf.py or the docs.

@jklenzing jklenzing requested a review from aburrell May 18, 2023 06:52
@jklenzing jklenzing merged commit 25f4a36 into develop May 19, 2023
@jklenzing jklenzing deleted the tst/ga_update branch May 19, 2023 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants