-
Notifications
You must be signed in to change notification settings - Fork 3
MAINT/BUG: GA updates, pandas 2.0+ compatibility #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Partial update to nose syntax issues while debugging the pandas updates. Documented in #127 |
Not sure what's going on in the doc tests |
- start).days != len(inst.files[start:stop]): | ||
missing_times = [tt for tt in pds.date_range(start, stop, freq='1D', | ||
closed='left') | ||
inclusive='left') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
closed
was deprecated in pandas 1.4.0 and removed in 2.0+
|
||
# Confirm time index information | ||
assert data_two_days.indexes['time'].is_monotonic | ||
assert data_two_days.indexes['time'].is_monotonic_increasing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is_monotonic
deprecated in pandas 1.5.0 and removed in 2.0+
.github/workflows/pip_rc_install.yml
Outdated
fail-fast: false | ||
matrix: | ||
os: ["ubuntu-latest", "macos-latest", "windows-latest"] | ||
python-version: ["3.10"] # Keep this version at the highest supported Python version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thought for the future: have this do the highest and lowest versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could probably do all supported versions since this test is quick.
Co-authored-by: Angeline Burrell <[email protected]>
See pysat/pysat#1120. New error related to Sphinx 7.0.0. Not sure what the root cause is yet. Apparently the 'style' key has been removed in this version, but I don't see where we invoke this in conf.py or the docs. |
Description
Updates GA environment to be compatible with latest environments. Updates to pip usage for RC installs.
Version cap on hacking until E275 is cleaned up in code.
Updates pandas syntax removed in 2.0.0 (
is_monotonic
andclose
kwarg).Type of change
How Has This Been Tested?
via pytest with pandas 2.0.0 installed.
Test Configuration:
Checklist:
develop
(notmain
) branchCHANGELOG.md
, summarizing the changesIf this is a release PR, replace the first item of the above checklist with the
release checklist on the pysat wiki:
https://github.com/pysat/pysat/wiki/Checklist-for-Release