handle mmap_write_byte_method

Dobatymo · Dobatymo · commit 79838690dcf9 · 2024-04-26T12:46:30.000+08:00
diff --git a/Misc/NEWS.d/next/Windows/2024-04-24-05-16-32.gh-issue-118209.Ryyzlz.rst b/Misc/NEWS.d/next/Windows/2024-04-24-05-16-32.gh-issue-118209.Ryyzlz.rst
@@ -1 +1,2 @@
-Fix crashes in :func:`mmap.read`, :func:`mmap.read_byte` and :func:`mmap.write` on Windows when the underlying file operation raises errors.
+Fix crashes in :func:`mmap.read`, :func:`mmap.read_byte`, :func:`mmap.write`
+and :func:`mmap.write_byte` on Windows when the underlying file operation raises errors.
diff --git a/Modules/mmapmodule.c b/Modules/mmapmodule.c
@@ -511,14 +511,18 @@ mmap_write_byte_method(mmap_object *self,
         return NULL;
 
     CHECK_VALID(NULL);
-    if (self->pos < self->size) {
-        self->data[self->pos++] = value;
-        Py_RETURN_NONE;
-    }
-    else {
+    if (self->pos >= self->size) {
         PyErr_SetString(PyExc_ValueError, "write byte out of range");
         return NULL;
     }
+
+    if (safe_memcpy(self->data + self->pos, value, 1) < 0) {
+        return NULL;
+    }
+    else {
+        self->pos++;
+        Py_RETURN_NONE;
+    }
 }
 
 static PyObject *

Original file line number	Diff line number	Diff line change
`@@ -1 +1,2 @@`
`1`		-Fix crashes in :func:`mmap.read`, :func:`mmap.read_byte` and :func:`mmap.write` on Windows when the underlying file operation raises errors.
	`1`	+Fix crashes in :func:`mmap.read`, :func:`mmap.read_byte`, :func:`mmap.write`
	`2`	+and :func:`mmap.write_byte` on Windows when the underlying file operation raises errors.