Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Make it possible to specify flags for pseudo instructions defined in bytecodes.c #112519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
iritkatriel opened this issue Nov 29, 2023 · 0 comments · Fixed by #112520
Closed

Make it possible to specify flags for pseudo instructions defined in bytecodes.c #112519

iritkatriel opened this issue Nov 29, 2023 · 0 comments · Fixed by #112520
Assignees
@iritkatriel
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs)

Comments

@iritkatriel
Copy link
Member

iritkatriel commented Nov 29, 2023 •
edited by bedevere-app bot
Loading

The instruction metadata is incorrect for some of the pseudo instructions. For instance, these map to NOP, and take their metadata from it, but they should have the HAS_ARG flag set.

  [SETUP_FINALLY] = { true, 0, 0 },
  [SETUP_CLEANUP] = { true, 0, 0 },
  [SETUP_WITH] = { true, 0, 0 },

We need to be able to specify flags for pseudo instructions in bytecodes.c (and relax assertions that it is identical to the target flags).

Linked PRs
@iritkatriel iritkatriel added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label Nov 29, 2023
@iritkatriel iritkatriel self-assigned this Nov 29, 2023
@iritkatriel iritkatriel mentioned this issue Nov 29, 2023
Merged
iritkatriel added a commit that referenced this issue Nov 30, 2023
@iritkatriel
gh-112519: Make it possible to specify instruction flags for pseudo i…
07ebd46 
…nstructions in bytecodes.c (#112520)
aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
@iritkatriel @aisk
pythongh-112519: Make it possible to specify instruction flags for ps…
3b5d911 
…eudo instructions in bytecodes.c (python#112520)
Glyphack pushed a commit to Glyphack/cpython that referenced this issue Sep 2, 2024
@iritkatriel @Glyphack
pythongh-112519: Make it possible to specify instruction flags for ps…
e4146e2 
…eudo instructions in bytecodes.c (python#112520)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iritkatriel iritkatriel

Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs)
Projects
None yet
Milestone
No milestone
1 participant
@iritkatriel