Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-112519: Make it possible to specify instruction flags for pseudo instructions in bytecodes.c #112520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 30, 2023
Merged

gh-112519: Make it possible to specify instruction flags for pseudo instructions in bytecodes.c #112520

merged 5 commits into from
Nov 30, 2023

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Nov 29, 2023 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Nov 29, 2023
Closed
iritkatriel
iritkatriel commented Nov 29, 2023
View reviewed changes
markshannon
markshannon reviewed Nov 30, 2023
View reviewed changes
Copy link
Member

@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor suggestion, and a type annotation needs fixing, otherwise LGTM.

iritkatriel
iritkatriel commented Nov 30, 2023
View reviewed changes
@iritkatriel iritkatriel enabled auto-merge (squash) November 30, 2023 10:41
@iritkatriel iritkatriel disabled auto-merge November 30, 2023 10:42
@iritkatriel iritkatriel merged commit 07ebd46 into python:main Nov 30, 2023
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@iritkatriel @aisk
pythongh-112519: Make it possible to specify instruction flags for ps…
3b5d911 
…eudo instructions in bytecodes.c (python#112520)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@iritkatriel @Glyphack
pythongh-112519: Make it possible to specify instruction flags for ps…
e4146e2 
…eudo instructions in bytecodes.c (python#112520)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markshannon markshannon markshannon left review comments

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make it possible to specify flags for pseudo instructions defined in bytecodes.c
2 participants
@iritkatriel @markshannon