Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Docs: upgrade to python-docs-theme 2023.7 #107617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 4, 2023

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Aug 4, 2023

The venv used on the docs server persists between deploys, therefore let's pin the theme so we get the version we want:

This means we'll get the dark theme for 3.11 (aka the main https://docs.python.org/3/). We've already had it on https://docs.python.org/3.12/ and https://docs.python.org/3.13/ for a few months.


Let's also bump Sphinx to include the latest 6.x patch release:

(We have another PR to upgrade Sphinx to 7.x, let's handle that separately: #99381)


📚 Documentation preview 📚: https://cpython-previews--107617.org.readthedocs.build/

Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could potentially do >=2023.7, but fairly minor.

A

@hugovk
Copy link
Member Author

hugovk commented Aug 4, 2023

Good idea, I'll update it to >=2023.7.

@hugovk hugovk enabled auto-merge (squash) August 4, 2023 14:01
@hugovk hugovk merged commit 19f32b2 into python:main Aug 4, 2023
@hugovk hugovk deleted the bump-python-docs-theme branch August 4, 2023 14:16
@miss-islington
Copy link
Contributor

Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @hugovk, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 19f32b24b2e1680ff9929bb64d681397b259c6fb 3.12

@miss-islington
Copy link
Contributor

Sorry, @hugovk, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 19f32b24b2e1680ff9929bb64d681397b259c6fb 3.11

hugovk added a commit to hugovk/cpython that referenced this pull request Aug 4, 2023
(cherry picked from commit 19f32b2)

Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-bot
Copy link

GH-107633 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Aug 4, 2023
@bedevere-bot
Copy link

GH-107634 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 4, 2023
hugovk added a commit to hugovk/cpython that referenced this pull request Aug 4, 2023
(cherry picked from commit 19f32b2)

Co-authored-by: Hugo van Kemenade <[email protected]>
Yhg1s pushed a commit that referenced this pull request Aug 4, 2023
hugovk added a commit that referenced this pull request Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants