-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
Docs: upgrade to python-docs-theme 2023.7 #107617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could potentially do >=2023.7
, but fairly minor.
A
Good idea, I'll update it to |
Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
Sorry, @hugovk, I could not cleanly backport this to |
Sorry, @hugovk, I could not cleanly backport this to |
(cherry picked from commit 19f32b2) Co-authored-by: Hugo van Kemenade <[email protected]>
GH-107633 is a backport of this pull request to the 3.12 branch. |
GH-107634 is a backport of this pull request to the 3.11 branch. |
(cherry picked from commit 19f32b2) Co-authored-by: Hugo van Kemenade <[email protected]>
The venv used on the docs server persists between deploys, therefore let's pin the theme so we get the version we want:
This means we'll get the dark theme for 3.11 (aka the main https://docs.python.org/3/). We've already had it on https://docs.python.org/3.12/ and https://docs.python.org/3.13/ for a few months.
Let's also bump Sphinx to include the latest 6.x patch release:
(We have another PR to upgrade Sphinx to 7.x, let's handle that separately: #99381)
📚 Documentation preview 📚: https://cpython-previews--107617.org.readthedocs.build/