gh-100414: Skip test_dbm_sqlite3 if sqlite3 is unavailable#115449
gh-100414: Skip test_dbm_sqlite3 if sqlite3 is unavailable#115449erlend-aasland merged 3 commits intopython:mainfrom
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
I think I prefer this fix. |
AlexWaygood
left a comment
There was a problem hiding this comment.
See my comments in #115448 (comment). This feels slightly more fragile to me, in that whether or not the test passes depends on the order the imports are in, which isn't necessarily obvious to the reader of the test. But either is probably fine; no strong preference :)
You could maybe add a comment noting that the imports need to be in precisely that order |
Yes, that seems fair to the future reader. |
Co-authored-by: Alex Waygood <[email protected]>
|
Thanks for the review(s), Alex! |
|
No worries! |
|
!buildbot AMD64 RHEL7 |
…hon#115449) Co-authored-by: Alex Waygood <[email protected]>
Alternative to #115448