-
-
Notifications
You must be signed in to change notification settings - Fork 32k
gh-100414: Skip test_dbm_sqlite3 if sqlite3 is unavailable #115448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, assuming it fixes the buildbots
We can also do this: diff --git a/Lib/test/test_dbm_sqlite3.py b/Lib/test/test_dbm_sqlite3.py
index 0eda8da4ab..7136b54016 100644
--- a/Lib/test/test_dbm_sqlite3.py
+++ b/Lib/test/test_dbm_sqlite3.py
@@ -6,9 +6,8 @@
from pathlib import Path
from test.support import cpython_only, import_helper, os_helper
-
-sqlite3 = import_helper.import_module("sqlite3")
dbm_sqlite3 = import_helper.import_module("dbm.sqlite3")
+import sqlite3
from dbm.sqlite3 import _normalize_uri
|
Not much difference between the two :) The advantage of #115449 is that the test will fail if As I say, very marginal, but I'd probably go for this one! |
Well, that should never be allowed to happen, which is why I prefer that PR :) |
Closed in favour of #115449. |
Uh oh!
There was an error while loading. Please reload this page.