gh-100414: Skip test_dbm_sqlite3 if sqlite3 is unavailable#115448
gh-100414: Skip test_dbm_sqlite3 if sqlite3 is unavailable#115448erlend-aasland wants to merge 1 commit intopython:mainfrom
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
AlexWaygood
left a comment
There was a problem hiding this comment.
LGTM, assuming it fixes the buildbots
We can also do this: diff --git a/Lib/test/test_dbm_sqlite3.py b/Lib/test/test_dbm_sqlite3.py
index 0eda8da4ab..7136b54016 100644
--- a/Lib/test/test_dbm_sqlite3.py
+++ b/Lib/test/test_dbm_sqlite3.py
@@ -6,9 +6,8 @@
from pathlib import Path
from test.support import cpython_only, import_helper, os_helper
-
-sqlite3 = import_helper.import_module("sqlite3")
dbm_sqlite3 = import_helper.import_module("dbm.sqlite3")
+import sqlite3
from dbm.sqlite3 import _normalize_uri
|
Not much difference between the two :) The advantage of #115449 is that the test will fail if As I say, very marginal, but I'd probably go for this one! |
Well, that should never be allowed to happen, which is why I prefer that PR :) |
|
Closed in favour of #115449. |
Uh oh!
There was an error while loading. Please reload this page.