Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-127529: Correct asyncio.selector_events.BaseSelectorEventLoop._accept_connection's behaviour for handling ConnectionAbortedError #127532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kumaraditya303 merged 7 commits into from
Jan 3, 2025
+36 −3
Merged

gh-127529: Correct asyncio.selector_events.BaseSelectorEventLoop._accept_connection's behaviour for handling ConnectionAbortedError #127532

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7ab3149
Fix gh-127529: Correct asyncio.selector_events.BaseSelectorEventLoop.…
jb2170 Dec 2, 2024
00f8fa3
Add NEWS article
jb2170 Dec 2, 2024
0f05a32
Remove :func:/:meth: from news article; doc checks don't like it for …
jb2170 Dec 2, 2024
317923d
Add BaseSelectorEventLoopTests.test_accept_connection_skip_connection…
jb2170 Dec 29, 2024
94afe3e
Update Lib/test/test_asyncio/test_selector_events.py
kumaraditya303 Jan 3, 2025
8182a2a
Update Misc/NEWS.d/next/Library/2024-12-02-19-13-19.gh-issue-127529.P…
kumaraditya303 Jan 3, 2025
651cdd9
Update Misc/NEWS.d/next/Library/2024-12-02-19-13-19.gh-issue-127529.P…
kumaraditya303 Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add BaseSelectorEventLoopTests.test_accept_connection_skip_connection… 
…abortederror to test graceful handling of ConnectionAbortedError
  • Loading branch information
@jb2170
jb2170 committed Dec 29, 2024
commit 317923d7bd8a4740e379922c2c5f44d70154dd34
25 changes: 25 additions & 0 deletions Lib/test/test_asyncio/test_selector_events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,6 +364,31 @@ def test_accept_connection_multiple(self):
self.loop.run_until_complete(asyncio.sleep(0))
self.assertEqual(sock.accept.call_count, backlog)

def test_accept_connection_skip_connectionabortederror(self):
sock = mock.Mock()

def mock_sock_accept():
# mock accept(2) returning -ECONNABORTED every-other
# time that it's called. This applies most to OpenBSD
# whose sockets generate this errno more reproducibly than
# Linux and other OSs.
Comment thread
kumaraditya303 marked this conversation as resolved.
Outdated
if sock.accept.call_count % 2 == 0:
raise ConnectionAbortedError
return (mock.Mock(), mock.Mock())

sock.accept.side_effect = mock_sock_accept
backlog = 100
# test that _accept_connection's loop calls sock.accept
# all 100 times, continuing past ConnectionAbortedError
# instead of unnecessarily returning early
mock_obj = mock.patch.object
with mock_obj(self.loop, '_accept_connection2') as accept2_mock:
self.loop._accept_connection(
mock.Mock(), sock, backlog=backlog)
# as in test_accept_connection_multiple avoid task pending
# warnings by using asyncio.sleep(0)
self.loop.run_until_complete(asyncio.sleep(0))
self.assertEqual(sock.accept.call_count, backlog)

class SelectorTransportTests(test_utils.TestCase):

Expand Down