-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
gh-133089: Use original timeout value for TimeoutExpired
when the func subprocess.run
is called with a timeout
#133103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
bfc8c24
gh-133089: Make `subprocess.run`'s behavior is same with 'timeout=Non…
Zheaoli 8c78390
Add news
Zheaoli 3924393
fix lint
Zheaoli 0bbe69e
Fix review idea
Zheaoli 1274363
Fix review idea
Zheaoli eca303d
format code
Zheaoli b9637d3
update docs
Zheaoli 5f746ee
update docs
Zheaoli c2863a7
Update docs
Zheaoli 01864f8
Update docs
Zheaoli 1534327
Update docs
Zheaoli 1e791e1
Update docs
Zheaoli 7f3aedb
Update docs
Zheaoli 8af708e
Add test
Zheaoli b3275b4
Fix windows test
Zheaoli b68164b
Modify timeout on the exiting exceptions.
gpshead a1967d7
reword news.
gpshead File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
Misc/NEWS.d/next/Library/2025-04-29-02-23-04.gh-issue-133089.8Jy1ZS.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
Use original timeout value for :exc:`subprocess.TimeoutExpired` | ||
when the func :meth:`subprocess.run` is called with a timeout | ||
instead of sometimes a confusing partial remaining time out value | ||
used internally on the final ``wait()``. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.