gh-133089: Use original timeout value for `TimeoutExpired` when the func `subprocess.run` is called with a timeout #133103

Zheaoli · 2025-04-28T18:23:47Z

Fix #133089

Issue: Negative run-time reported by subprocess.run's TimeoutExpired exception when setting timeout=0 #133089

…ut=None' when the timeout is zero Signed-off-by: Manjusaka <[email protected]>

Signed-off-by: Manjusaka <[email protected]>

StanFromIreland

What about a negative timeout? Why does wait need this too?

This needs doc updates, and a test.

Misc/NEWS.d/next/Library/2025-04-29-02-23-04.gh-issue-133089.8Jy1ZS.rst

Zheaoli · 2025-04-28T19:02:46Z

What about a negative timeout?

How about raise ValueError when timeout is <=0

StanFromIreland · 2025-04-28T19:08:55Z

Hmm, looking at bash functions I get conflicting results. timeout throws an error for negative values and has no limit on 0, whereas other functions (e.g. read -t 0) actually use the limit (they stop instantly).

Yes, a value error is the way to go for negative timeouts.

ZeroIntensity

I don't think timeout=0 should be treated the same as timeout=None. This isn't done anywhere else in the standard library. For example, using asyncio as precedent:

import asyncio

async def main():
    async with asyncio.timeout(None):
        await asyncio.sleep(0)
        print("No timeout!")

    async with asyncio.timeout(0):
        await asyncio.sleep(0)  # TimeoutError

asyncio.run(main())

I think it would be better to fix the negative time.

Lib/subprocess.py

Zheaoli · 2025-05-01T18:10:42Z

I don't think timeout=0 should be treated the same as timeout=None. This isn't done anywhere else in the standard library. For example, using asyncio as precedent:

Make sense, I'll find a way to patch it

Signed-off-by: Manjusaka <[email protected]>

gpshead

I think your documentation addition is useful, but the logic change is not what we want.

If you want a cleaner value in the TimeoutExpired error message in this situation, that could be done by catching and replacing the info in the TimeoutExpired exception from Popen._communicate's self.wait(timeout=self._remaining_time(endtime)) with the orig_timeout value that is known at that point. .wait() itself cannot meaningfully know that value.

Lib/subprocess.py

bedevere-app · 2025-05-03T05:30:51Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Signed-off-by: Manjusaka <[email protected]>

Doc/library/subprocess.rst

Signed-off-by: Manjusaka <[email protected]>

miss-islington-app · 2025-05-05T01:15:35Z

Thanks @Zheaoli for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

… the func `subprocess.run` is called with a timeout (pythonGH-133103) (cherry picked from commit 2bbcaed) Co-authored-by: Nadeshiko Manju <[email protected]> Signed-off-by: Manjusaka <[email protected]> Co-authored-by: Gregory P. Smith <[email protected]>

bedevere-app · 2025-05-05T01:15:45Z

GH-133418 is a backport of this pull request to the 3.13 branch.

…n the func `subprocess.run` is called with a timeout (GH-133103) (#133418) gh-133089: Use original timeout value for `TimeoutExpired` when the func `subprocess.run` is called with a timeout (GH-133103) (cherry picked from commit 2bbcaed) Signed-off-by: Manjusaka <[email protected]> Co-authored-by: Nadeshiko Manju <[email protected]> Co-authored-by: Gregory P. Smith <[email protected]>

bedevere-bot · 2025-05-05T01:41:31Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL8 LTO + PGO 3.x (tier-3) has failed when building commit 2bbcaed.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/442/builds/9283) and take a look at the build logs.
Check if the failure is related to this commit (2bbcaed) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/442/builds/9283

Failed tests:

test_frame
test_subprocess

Failed subtests:

test_timeout_exception - test.test_subprocess.ProcessTestCaseNoPoll.test_timeout_exception

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.lto-pgo/build/Lib/test/test_subprocess.py", line 171, in test_timeout_exception
    self.fail("Expected TimeoutExpired exception not raised")
    ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: Expected TimeoutExpired exception not raised

bedevere-bot · 2025-05-05T01:43:48Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora Stable Clang Installed 3.x (tier-3) has failed when building commit 2bbcaed.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1645/builds/352) and take a look at the build logs.
Check if the failure is related to this commit (2bbcaed) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1645/builds/352

Failed tests:

test_subprocess

Failed subtests:

test_timeout_exception - test.test_subprocess.ProcessTestCaseNoPoll.test_timeout_exception
test_timeout_exception - test.test_subprocess.ProcessTestCase.test_timeout_exception

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x.clang-installed/build/target/lib/python3.14/test/test_subprocess.py", line 177, in test_timeout_exception
    self.fail("Expected TimeoutExpired exception not raised")
    ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: Expected TimeoutExpired exception not raised


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x.clang-installed/build/target/lib/python3.14/test/test_subprocess.py", line 171, in test_timeout_exception
    self.fail("Expected TimeoutExpired exception not raised")
    ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: Expected TimeoutExpired exception not raised

bedevere-bot · 2025-05-05T01:52:24Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora Stable LTO + PGO 3.x (tier-3) has failed when building commit 2bbcaed.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1627/builds/352) and take a look at the build logs.
Check if the failure is related to this commit (2bbcaed) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1627/builds/352

Failed tests:

test_subprocess

Failed subtests:

test_timeout_exception - test.test_subprocess.ProcessTestCaseNoPoll.test_timeout_exception
test_timeout_exception - test.test_subprocess.ProcessTestCase.test_timeout_exception

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x.lto-pgo/build/Lib/test/test_subprocess.py", line 171, in test_timeout_exception
    self.fail("Expected TimeoutExpired exception not raised")
    ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: Expected TimeoutExpired exception not raised

bedevere-bot · 2025-05-05T01:59:06Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Windows Server 2022 NoGIL 3.13 (tier-1) has failed when building commit 3d1b8e2.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1488/builds/1266) and take a look at the build logs.
Check if the failure is related to this commit (3d1b8e2) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1488/builds/1266

Failed tests:

test_subprocess

Failed subtests:

test_timeout_exception - test.test_subprocess.ProcessTestCase.test_timeout_exception

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "C:\Users\Administrator\buildarea\3.13.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_subprocess.py", line 166, in test_timeout_exception
    subprocess.run(['echo', 'hi'], timeout = -1)
    ~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\Administrator\buildarea\3.13.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\subprocess.py", line 554, in run
    with Popen(*popenargs, **kwargs) as process:
         ~~~~~^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\Administrator\buildarea\3.13.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\subprocess.py", line 1039, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
    ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                        pass_fds, cwd, env,
                        ^^^^^^^^^^^^^^^^^^^
    ...<5 lines>...
                        gid, gids, uid, umask,
                        ^^^^^^^^^^^^^^^^^^^^^^
                        start_new_session, process_group)
                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\Administrator\buildarea\3.13.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\subprocess.py", line 1554, in _execute_child
    hp, ht, pid, tid = _winapi.CreateProcess(executable, args,
                       ~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^
                             # no special security
                             ^^^^^^^^^^^^^^^^^^^^^
    ...<4 lines>...
                             cwd,
                             ^^^^
                             startupinfo)
                             ^^^^^^^^^^^^
FileNotFoundError: [WinError 2] The system cannot find the file specified

bedevere-bot · 2025-05-05T02:04:41Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora Stable 3.13 (tier-3) has failed when building commit 3d1b8e2.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1658/builds/128) and take a look at the build logs.
Check if the failure is related to this commit (3d1b8e2) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1658/builds/128

Failed tests:

test_os
test_subprocess

Failed subtests:

test_timerfd_select - test.test_os.TimerfdTests.test_timerfd_select
test_timeout_exception - test.test_subprocess.ProcessTestCase.test_timeout_exception
test_timeout_exception - test.test_subprocess.ProcessTestCaseNoPoll.test_timeout_exception

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.13.cstratak-fedora-stable-s390x/build/Lib/test/test_os.py", line 4288, in test_timerfd_select
    self.assertEqual(self.read_count_signaled(fd), 1)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 2 != 1


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.13.cstratak-fedora-stable-s390x/build/Lib/test/test_subprocess.py", line 170, in test_timeout_exception
    self.fail("Expected TimeoutExpired exception not raised")
    ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: Expected TimeoutExpired exception not raised

bedevere-bot · 2025-05-05T02:09:16Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL9 LTO 3.13 (tier-3) has failed when building commit 3d1b8e2.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1577/builds/702) and take a look at the build logs.
Check if the failure is related to this commit (3d1b8e2) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1577/builds/702

Failed tests:

test_subprocess

Failed subtests:

test_timeout_exception - test.test_subprocess.ProcessTestCase.test_timeout_exception

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.13.cstratak-rhel9-s390x.lto/build/Lib/test/test_subprocess.py", line 170, in test_timeout_exception
    self.fail("Expected TimeoutExpired exception not raised")
    ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: Expected TimeoutExpired exception not raised

bedevere-bot · 2025-05-05T02:09:53Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora Stable Clang 3.13 (tier-3) has failed when building commit 3d1b8e2.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1667/builds/128) and take a look at the build logs.
Check if the failure is related to this commit (3d1b8e2) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1667/builds/128

Failed tests:

test_subprocess

Failed subtests:

test_timeout_exception - test.test_subprocess.ProcessTestCaseNoPoll.test_timeout_exception
test_timeout_exception - test.test_subprocess.ProcessTestCase.test_timeout_exception

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.13.cstratak-fedora-stable-s390x.clang/build/Lib/test/test_subprocess.py", line 176, in test_timeout_exception
    self.fail("Expected TimeoutExpired exception not raised")
    ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: Expected TimeoutExpired exception not raised


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.13.cstratak-fedora-stable-s390x.clang/build/Lib/test/test_subprocess.py", line 170, in test_timeout_exception
    self.fail("Expected TimeoutExpired exception not raised")
    ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: Expected TimeoutExpired exception not raised

bedevere-bot · 2025-05-05T02:46:55Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Ubuntu Shared 3.x (tier-1) has failed when building commit 2bbcaed.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/506/builds/10590) and take a look at the build logs.
Check if the failure is related to this commit (2bbcaed) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/506/builds/10590

Failed tests:

test_subprocess

Failed subtests:

test_timeout_exception - test.test_subprocess.ProcessTestCaseNoPoll.test_timeout_exception
test_remote_stack_trace - test.test_external_inspection.TestGetStackTrace.test_remote_stack_trace
test_timeout_exception - test.test_subprocess.ProcessTestCase.test_timeout_exception

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_subprocess.py", line 171, in test_timeout_exception
    self.fail("Expected TimeoutExpired exception not raised")
    ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: Expected TimeoutExpired exception not raised


Traceback (most recent call last):
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_external_inspection.py", line 104, in test_remote_stack_trace
    self.assertEqual(stack_trace, expected_stack_trace)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: Lists differ: [('fo[62 chars]y', 14), ('baz', '/tmp/test_python_m2xu4jch/tm[186 chars] 17)] != [('fo[62 chars]y', 15), ('baz', '/tmp/test_python_m2xu4jch/tm[186 chars] 17)]


Traceback (most recent call last):
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_subprocess.py", line 177, in test_timeout_exception
    self.fail("Expected TimeoutExpired exception not raised")
    ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: Expected TimeoutExpired exception not raised

bedevere-bot · 2025-05-05T03:12:38Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora Stable Refleaks 3.13 (tier-3) has failed when building commit 3d1b8e2.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1662/builds/133) and take a look at the build logs.
Check if the failure is related to this commit (3d1b8e2) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1662/builds/133

Failed tests:

test_subprocess
test_socket

Failed subtests:

testSourceAddress - test.test_socket.NetworkConnectionAttributesTest.testSourceAddress
test_timeout_exception - test.test_subprocess.ProcessTestCase.test_timeout_exception

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.13.cstratak-fedora-stable-s390x.refleak/build/Lib/test/test_subprocess.py", line 170, in test_timeout_exception
    self.fail("Expected TimeoutExpired exception not raised")
    ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: Expected TimeoutExpired exception not raised


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.13.cstratak-fedora-stable-s390x.refleak/build/Lib/test/test_socket.py", line 417, in raise_queued_exception
    raise self.queue.get()
  File "/home/buildbot/buildarea/3.13.cstratak-fedora-stable-s390x.refleak/build/Lib/test/test_socket.py", line 454, in clientRun
    test_func()
    ~~~~~~~~~^^
  File "/home/buildbot/buildarea/3.13.cstratak-fedora-stable-s390x.refleak/build/Lib/test/test_socket.py", line 5783, in _testSourceAddress
    self.assertEqual(self.cli.getsockname()[1], self.source_port)
                     ~~~~~~~~~~~~~~~~~~~~^^
OSError: [Errno 9] Bad file descriptor

bedevere-bot · 2025-05-05T03:24:32Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 FreeBSD Refleaks 3.13 (tier-3) has failed when building commit 3d1b8e2.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1615/builds/733) and take a look at the build logs.
Check if the failure is related to this commit (3d1b8e2) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1615/builds/733

Failed tests:

test_subprocess

Failed subtests:

test_timeout_exception - test.test_subprocess.ProcessTestCaseNoPoll.test_timeout_exception
test_timeout_exception - test.test_subprocess.ProcessTestCase.test_timeout_exception

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/buildbot/buildarea/3.13.ware-freebsd.refleak/build/Lib/test/test_subprocess.py", line 176, in test_timeout_exception
    self.fail("Expected TimeoutExpired exception not raised")
    ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: Expected TimeoutExpired exception not raised

The few buildbot failures on python#133103 are possibly just due to racing a child process launch and exit?

The few buildbot failures on #133103 are possibly just due to racing a child process launch and exit?

…GH-133420) The few buildbot failures on python#133103 are possibly just due to racing a child process launch and exit? (cherry picked from commit b64aa30) Co-authored-by: Gregory P. Smith <[email protected]>

…H-133420) (#133421) [tests] test_subprocess maybe avoid a timeout race condition? (GH-133420) The few buildbot failures on #133103 are possibly just due to racing a child process launch and exit? (cherry picked from commit b64aa30) Co-authored-by: Gregory P. Smith <[email protected]>

Zheaoli added 2 commits April 29, 2025 02:22

pythongh-133089: Make subprocess.run's behavior is same with 'timeo…

bfc8c24

…ut=None' when the timeout is zero Signed-off-by: Manjusaka <[email protected]>

Add news

8c78390

Signed-off-by: Manjusaka <[email protected]>

Zheaoli requested a review from gpshead as a code owner April 28, 2025 18:23

bedevere-app bot added the awaiting review label Apr 28, 2025

bedevere-app bot mentioned this pull request Apr 28, 2025

Negative run-time reported by subprocess.run's TimeoutExpired exception when setting timeout=0 #133089

Closed

fix lint

3924393

Signed-off-by: Manjusaka <[email protected]>

StanFromIreland suggested changes Apr 28, 2025

View reviewed changes

bedevere-app bot added awaiting core review and removed awaiting review labels Apr 28, 2025

StanFromIreland reviewed Apr 28, 2025

View reviewed changes

Misc/NEWS.d/next/Library/2025-04-29-02-23-04.gh-issue-133089.8Jy1ZS.rst Outdated Show resolved Hide resolved

ZeroIntensity requested changes May 1, 2025

View reviewed changes

Lib/subprocess.py Outdated Show resolved Hide resolved

Zheaoli added 4 commits May 3, 2025 12:50

Fix review idea

0bbe69e

Signed-off-by: Manjusaka <[email protected]>

Fix review idea

1274363

Signed-off-by: Manjusaka <[email protected]>

format code

eca303d

Signed-off-by: Manjusaka <[email protected]>

update docs

b9637d3

Signed-off-by: Manjusaka <[email protected]>

gpshead requested changes May 3, 2025

View reviewed changes

Lib/subprocess.py Outdated Show resolved Hide resolved

bedevere-app bot removed the awaiting core review label May 3, 2025

bedevere-app bot added the awaiting changes label May 3, 2025

Zheaoli added 2 commits May 3, 2025 22:02

update docs

5f746ee

Signed-off-by: Manjusaka <[email protected]>

Update docs

c2863a7

Signed-off-by: Manjusaka <[email protected]>

Zheaoli changed the title ~~gh-133089: Make subprocess.run's behavior is same with 'timeout=None' when the timeout is zero~~ gh-133089: Use origional timeout value for TimeoutExpired when the func subprocess.run is called with a timeout May 4, 2025

Update docs

01864f8

Signed-off-by: Manjusaka <[email protected]>

StanFromIreland reviewed May 4, 2025

View reviewed changes

Doc/library/subprocess.rst Show resolved Hide resolved

Zheaoli added 3 commits May 4, 2025 20:30

Update docs

1534327

Signed-off-by: Manjusaka <[email protected]>

Update docs

1e791e1

Signed-off-by: Manjusaka <[email protected]>

Update docs

7f3aedb

Signed-off-by: Manjusaka <[email protected]>

reword news.

a1967d7

gpshead approved these changes May 5, 2025

View reviewed changes

bedevere-app bot added awaiting merge and removed awaiting core review labels May 5, 2025

gpshead added the needs backport to 3.13 bugs and security fixes label May 5, 2025

gpshead changed the title ~~gh-133089: Use origional timeout value for TimeoutExpired when the func subprocess.run is called with a timeout~~ gh-133089: Use original timeout value for TimeoutExpired when the func subprocess.run is called with a timeout May 5, 2025

gpshead enabled auto-merge (squash) May 5, 2025 01:04

gpshead merged commit 2bbcaed into python:main May 5, 2025
45 checks passed

bedevere-app bot removed the awaiting merge label May 5, 2025

bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 5, 2025

gpshead added a commit to gpshead/cpython that referenced this pull request May 5, 2025

[tests] test_subprocess maybe avoid a timeout race condition?

9063e79

The few buildbot failures on python#133103 are possibly just due to racing a child process launch and exit?

gpshead mentioned this pull request May 5, 2025

[tests] test_subprocess maybe avoid a timeout race condition? #133420

Merged

gpshead added a commit that referenced this pull request May 5, 2025

[tests] test_subprocess maybe avoid a timeout race condition? (#133420)

b64aa30

The few buildbot failures on #133103 are possibly just due to racing a child process launch and exit?

miss-islington mentioned this pull request May 5, 2025

[3.13] [tests] test_subprocess maybe avoid a timeout race condition? (GH-133420) #133421

Merged

Uh oh!

gh-133089: Use original timeout value for TimeoutExpired when the func subprocess.run is called with a timeout #133103

gh-133089: Use original timeout value for TimeoutExpired when the func subprocess.run is called with a timeout #133103

Uh oh!

Conversation

Zheaoli commented Apr 28, 2025 • edited by bedevere-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

StanFromIreland left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Zheaoli commented Apr 28, 2025

Uh oh!

StanFromIreland commented Apr 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZeroIntensity left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Zheaoli commented May 1, 2025

Uh oh!

gpshead left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bedevere-app bot commented May 3, 2025

Uh oh!

Uh oh!

Uh oh!

miss-islington-app bot commented May 5, 2025

Uh oh!

bedevere-app bot commented May 5, 2025

Uh oh!

bedevere-bot commented May 5, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented May 5, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented May 5, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented May 5, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented May 5, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented May 5, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented May 5, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented May 5, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented May 5, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented May 5, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Uh oh!

gh-133089: Use original timeout value for `TimeoutExpired` when the func `subprocess.run` is called with a timeout #133103

gh-133089: Use original timeout value for `TimeoutExpired` when the func `subprocess.run` is called with a timeout #133103

Zheaoli commented Apr 28, 2025 •

edited by bedevere-app bot

Loading

StanFromIreland commented Apr 28, 2025 •

edited

Loading