Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[tests] test_subprocess maybe avoid a timeout race condition? #133420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2025
Merged

[tests] test_subprocess maybe avoid a timeout race condition? #133420

merged 1 commit into from
May 5, 2025

Conversation

gpshead
Copy link
Member

@gpshead gpshead commented May 5, 2025

The few buildbot failures on #133103 are possibly just due to racing a child process launch and exit?

@gpshead
[tests] test_subprocess maybe avoid a timeout race condition?
9063e79 
The few buildbot failures on python#133103
are possibly just due to racing a child process launch and exit?
@gpshead gpshead added tests Tests in the Lib/test dir skip issue skip news needs backport to 3.13 bugs and security fixes labels May 5, 2025
@gpshead
Copy link
Member Author

gpshead commented May 5, 2025

!buildbot .s390.

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @gpshead for commit 9063e79 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133420%2Fmerge

The command will test the builders whose names match following regular expression: .*s390.*

The builders matched are:

  • s390x Fedora Rawhide PR
  • s390x Fedora Stable LTO + PGO PR
  • s390x Fedora Stable PR
  • s390x Fedora Rawhide NoGIL PR
  • s390x Fedora Rawhide Refleaks PR
  • s390x RHEL9 LTO + PGO PR
  • s390x Fedora Rawhide NoGIL refleaks PR
  • s390x RHEL9 PR
  • s390x Fedora Stable LTO PR
  • s390x RHEL8 PR
  • s390x RHEL9 LTO PR
  • s390x Fedora Stable Clang Installed PR
  • s390x Fedora Stable Refleaks PR
  • s390x Fedora Rawhide Clang PR
  • s390x RHEL9 Refleaks PR
  • s390x Fedora Rawhide LTO + PGO PR
  • s390x Fedora Rawhide Clang Installed PR
  • s390x RHEL8 Refleaks PR
  • s390x RHEL8 LTO + PGO PR
  • s390x Fedora Stable Clang PR
  • s390x Fedora Rawhide LTO PR
  • s390x RHEL8 LTO PR

@gpshead
Copy link
Member Author

gpshead commented May 5, 2025

!buildbot .Server.2022.

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @gpshead for commit 9063e79 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133420%2Fmerge

The command will test the builders whose names match following regular expression: .*Server.2022.*

The builders matched are:

  • AMD64 Windows Server 2022 NoGIL PR

@emmatyping
Copy link
Member

It looks like the race is surfacing on Ubuntu freethreaded CI (e.g. https://github.com/python/cpython/actions/runs/14827808058/job/41623568354?pr=133365) so if it is fixed there that should be a good signal.

@emmatyping
Copy link
Member

The hypothesis failure looks similar to a failure I saw. I filed #133419 to track the test_external_inspection failures.

@gpshead gpshead merged commit b64aa30 into python:main May 5, 2025
58 of 66 checks passed
@miss-islington-app
Copy link

Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 5, 2025
@gpshead @miss-islington
[tests] test_subprocess maybe avoid a timeout race condition? (python…
5f69fc2 
…GH-133420)

The few buildbot failures on python#133103
are possibly just due to racing a child process launch and exit?
(cherry picked from commit b64aa30)

Co-authored-by: Gregory P. Smith <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented May 5, 2025

GH-133421 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 5, 2025
@Zheaoli
Copy link
Contributor

Zheaoli commented May 5, 2025

ops, sorry about this. Thanks for the patch!

gpshead added a commit that referenced this pull request May 5, 2025
@miss-islington @gpshead
[3.13] [tests] test_subprocess maybe avoid a timeout race condition? (G…
e89ca39 
…H-133420) (#133421)

[tests] test_subprocess maybe avoid a timeout race condition? (GH-133420)

The few buildbot failures on #133103
are possibly just due to racing a child process launch and exit?
(cherry picked from commit b64aa30)

Co-authored-by: Gregory P. Smith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmatyping emmatyping emmatyping approved these changes

Assignees
No one assigned
Labels
skip issue skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gpshead @bedevere-bot @emmatyping @Zheaoli