bpo-30241: implement contextlib.AbstractAsyncContextManager #1412
Conversation
|
@JelleZijlstra, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ncoghlan, @birkenfeld and @rhettinger to be potential reviewers. |
Lib/contextlib.py
Outdated
| def __subclasshook__(cls, C): | ||
| if cls is AbstractAsyncContextManager: | ||
| if (any("__aenter__" in B.__dict__ for B in C.__mro__) and | ||
| any("__aexit__" in B.__dict__ for B in C.__mro__)): |
There was a problem hiding this comment.
I understand you just copied this from above, but I think both should be updated to support the explicit "anti-registration" __enter__ = None pattern, like all classes in collections.abc, see _check_methods function in _collections_abc.py.
There was a problem hiding this comment.
Maybe that should be a separate issue? AbstractContextManager should arguably be fixed even in 3.6, and this PR only targets 3.7. I can fix AbstractAsyncContextManager though.
There was a problem hiding this comment.
Yes, a separate PR for 3.6 is needed. But I think it makes sense to already fix the async version here.
There was a problem hiding this comment.
Filed http://bugs.python.org/issue30266 to track that.
|
Wait, isn't this a new feature that should go into 3.7? |
Oh yes, sorry, this one is not urgent then. |
Implements: - python/typing#438 - python/cpython#360 python/cpython#1412, which adds contextlib.AbstractAsyncContextManager, has not yet been merged.
) Implements: - python/typing#438 - python/cpython#360 Note that python/cpython#1412, which adds contextlib.AbstractAsyncContextManager, has not yet been merged.
|
Please add a NEWS entry and I'll merge this in. |
|
Thanks, just pushed a NEWS entry. |
Doc/library/contextlib.rst
Outdated
| @@ -29,6 +29,15 @@ Functions and classes provided: | |||
| .. versionadded:: 3.6 | |||
|
|
|||
|
|
|||
| .. class:: AbstractAsyncContextManager | |||
|
|
|||
| An :term:`abstract base class` similar to | |||
There was a problem hiding this comment.
I'm wondering if we could just copy the paragraph from AbstractContextManager doc. "similar to" isn't easy to read here.
|
The PR #4790 adds |
|
@JelleZijlstra Could you please fix the merge conflict and update the docs as @1st1 proposed? I would like to have this merged soon. |
|
Thanks @JelleZijlstra! |
|
Thanks, and sorry for dropping the ball on making the docs change! |
|
NP ;) |
|
Thank you @JelleZijlstra and @1st1 ! |
https://bugs.python.org/issue30241