-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
bpo-40263: Fix off-by-one-error in _winapi_WaitForMultipleObjects_impl #19501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c5b5316
to
cf49f02
Compare
It's unclear to me why the EDIT: I see it now, though it's unfortunate that we get limited to 63 even in non-main threads. |
@zooba, you mentioned on b.p.o. that this was a good fix. Want to review this? |
Got hit by this again, would be great if this patch is merged upstream! |
Plus one for please merge! Currently having to work around this. |
@nehaljwani you aren't using anaconda python? /me cries. 😀 |
@mingwandroid I am, an upgrade to the patched build resolved the issue, however I'd still like to see this merged 😄 |
Is this trivial, somewhat important fix really going to make it to 1 year old before anyone reviews it? Ping @zooba |
Pinging @zooba for a review. |
Sorry that I missed all the pings. Wish I could have resolved this while Ray was still with us to see it. |
Thanks @mingwandroid for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9. |
GH-27428 is a backport of this pull request to the 3.10 branch. |
GH-27429 is a backport of this pull request to the 3.9 branch. |
…s_impl (pythonGH-19501) (cherry picked from commit 92b5dc7) Co-authored-by: Ray Donnelly <[email protected]>
…s_impl (pythonGH-19501) (cherry picked from commit 92b5dc7) Co-authored-by: Ray Donnelly <[email protected]>
…s_impl (GH-19501) (cherry picked from commit 92b5dc7) Co-authored-by: Ray Donnelly <[email protected]>
…s_impl (GH-19501) (cherry picked from commit 92b5dc7) Co-authored-by: Ray Donnelly <[email protected]>
Fix off-by-one-error in _winapi_WaitForMultipleObjects_impl
https://bugs.python.org/issue40263