Thanks to visit codestin.com
Credit goes to github.com

Skip to content

bpo-40263: Fix off-by-one-error in _winapi_WaitForMultipleObjects_impl #19501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2021

Conversation

mingwandroid
Copy link
Contributor

@mingwandroid mingwandroid commented Apr 13, 2020

Fix off-by-one-error in _winapi_WaitForMultipleObjects_impl

https://bugs.python.org/issue40263

@mingwandroid mingwandroid changed the title Fix off-by-one-error in _winapi_WaitForMultipleObjects_impl [bpo-40263](https://bugs.python.org/issue40263): Fix off-by-one-error in _winapi_WaitForMultipleObjects_impl Apr 13, 2020
@cbezault
Copy link

cbezault commented Apr 13, 2020

It's unclear to me why the -1 is needed? Do we need to reserve a slot for some other handle?

EDIT: I see it now, though it's unfortunate that we get limited to 63 even in non-main threads.

@aeros aeros changed the title [bpo-40263](https://bugs.python.org/issue40263): Fix off-by-one-error in _winapi_WaitForMultipleObjects_impl bpo-40263: Fix off-by-one-error in _winapi_WaitForMultipleObjects_impl Apr 15, 2020
@taleinat
Copy link
Contributor

@zooba, you mentioned on b.p.o. that this was a good fix. Want to review this?

@nehaljwani
Copy link

Got hit by this again, would be great if this patch is merged upstream!

@FaustinCarter
Copy link

Plus one for please merge! Currently having to work around this.

@mingwandroid
Copy link
Contributor Author

@nehaljwani you aren't using anaconda python? /me cries. 😀

@nehaljwani
Copy link

@mingwandroid I am, an upgrade to the patched build resolved the issue, however I'd still like to see this merged 😄

@mingwandroid
Copy link
Contributor Author

Is this trivial, somewhat important fix really going to make it to 1 year old before anyone reviews it? Ping @zooba

@mingwandroid
Copy link
Contributor Author

Pinging @zooba for a review.

@zooba zooba closed this Jul 28, 2021
@zooba zooba reopened this Jul 28, 2021
@zooba zooba added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Jul 28, 2021
@zooba
Copy link
Member

zooba commented Jul 28, 2021

Sorry that I missed all the pings. Wish I could have resolved this while Ray was still with us to see it.

@zooba zooba merged commit 92b5dc7 into python:main Jul 28, 2021
@miss-islington
Copy link
Contributor

Thanks @mingwandroid for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

GH-27428 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jul 28, 2021
@bedevere-bot
Copy link

GH-27429 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Jul 28, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 28, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 28, 2021
miss-islington added a commit that referenced this pull request Jul 28, 2021
…s_impl (GH-19501)

(cherry picked from commit 92b5dc7)

Co-authored-by: Ray Donnelly <[email protected]>
zooba pushed a commit that referenced this pull request Jul 28, 2021
…s_impl (GH-19501)

(cherry picked from commit 92b5dc7)

Co-authored-by: Ray Donnelly <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants