Better error message for nested TypedDict - #11658
Merged
Merged
Conversation
JukkaL
approved these changes
Dec 3, 2021
JukkaL
left a comment
Collaborator
There was a problem hiding this comment.
Thanks! Left one idea about tweaking the error message (optional). Feel free to merge.
| isinstance(field_type_expr.callee, RefExpr) and | ||
| field_type_expr.callee.fullname in TPDICT_NAMES): | ||
| self.fail_typeddict_arg( | ||
| 'Inline TypedDict types not supported; use assignment', |
Collaborator
There was a problem hiding this comment.
Bikeshedding: What about making this more detailed, such as like this:
Inline TypedDict types not supported; use assignment to define TypedDict
tushar-deepsource
pushed a commit
to DeepSourceCorp/mypy
that referenced
this pull request
Jan 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #4299
Test Plan
Add a new test case
testCannotCreateTypedDictInstanceWithInlineTypedDict