Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Library/base64 #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 26, 2024
Merged

Library/base64 #648

merged 10 commits into from
Apr 26, 2024

Conversation

Yang92047111
Copy link
Contributor

No description provided.

Copy link
Collaborator

@mattwang44 mattwang44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review part 1

有用到不少簡中慣用用法,再麻煩幫忙修正:

  • interface: 接口 -> 介面
  • string: 字符串 -> 字串
  • return: 返回 -> 回傳
  • mapping: 映射 -> 對映
  • binary/hex: xx進制 -> xx進位
  • support: 支持 -> 支援
  • object: 對象 -> 物件
  • file: 文件 -> 檔案
  • Internet: 互聯網 -> 網際網路

下個階段再 review 翻譯正確性與暢通性

@Yang92047111
Copy link
Contributor Author

Got it!

@Yang92047111
Copy link
Contributor Author

Thanks!

@mattwang44
Copy link
Collaborator

@Yang92047111
想請問你會繼續修這隻 PR 嗎?

@Yang92047111
Copy link
Contributor Author

不好意思,這週會把它完成!

@mattwang44 mattwang44 requested a review from ken71301 November 13, 2023 03:42
@mattwang44
Copy link
Collaborator

@ken71301 想麻煩你繼續 review 這個 PR,感謝 🙏🏽

@ken71301
Copy link
Collaborator

ok~

@ken71301
Copy link
Collaborator

Copy link
Collaborator

@ken71301 ken71301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review 完畢

主要需注意:

  • 仍有翻譯為簡中用詞
  • 部分語句不通順與翻譯錯漏
  • 部分用詞與專案現有翻譯不同
  • rst語法的雙引號部分
  • alphabet於現有翻譯中為 字母
  • character 於樂詞網中建議翻為字元

@ken71301
Copy link
Collaborator

ken71301 commented Dec 4, 2023

@Yang92047111
想請問你會繼續修這隻 PR 嗎?

@Yang92047111
Copy link
Contributor Author

不好意思,這週會Push一版!

Copy link
Collaborator

@ken71301 ken71301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review part 4,
Still loads of stuff should be fix, many of them were mentioned in previous reviews already, ty.

@mattwang44 mattwang44 self-requested a review January 2, 2024 03:45
Copy link
Collaborator

@mattwang44 mattwang44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yang92047111
想請你先修正以下問題,要麻煩你檢查 PR 所有出現的地方(review comment 可能只會註明一處,不會全部指出):

  • 修正字詞翻譯
    • flag -> 旗標
    • bytes -> 翻成「位元組」而非「字節」
    • optional -> 可選的
    • character -> 翻成「字元」而非「字符」
    • implementation -> 統一翻成「實作」,目前還是有錯譯的地方
    • security purposes -> 宜譯作「安全性考量」
  • 請記得留空格的規則:
    • 全形標點符號與中文字、英文字母、羅馬數字間皆不需要留空格
    • 中文字與英文字母、數字間需要留空格
  • 目前使用雙斜線的時機,大多不必要或者錯誤,請先麻煩你讀懂這篇說明後進行修正
  • nit: PO 檔案的慣例是會為了更好的閱讀性而斷行,但斷行位置不會是讓編輯者自行花時間判斷,請使用 pogrep 這項工具來幫助你做格式化(請參考這份文件

Copy link
Collaborator

@mattwang44 mattwang44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work! almost there

@mattwang44 mattwang44 self-requested a review January 18, 2024 07:27
Copy link
Collaborator

@mattwang44 mattwang44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

抱歉擱置過久
我覺得目前翻譯已經夠好了,我補上幾個小 patch 後就 merge 🙏🏽

@mattwang44 mattwang44 enabled auto-merge (squash) April 26, 2024 10:03
@mattwang44 mattwang44 merged commit 15602e1 into python:3.12 Apr 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants