chore: add testing of Python 3.14 #3023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a40352e to
f9fb93a
Compare
f9fb93a to
f7749dc
Compare
|
@nejch This ended up being easier than I thought it would be. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3023 +/- ##
==========================================
- Coverage 96.62% 96.62% -0.01%
==========================================
Files 95 95
Lines 6101 6099 -2
==========================================
- Hits 5895 5893 -2
Misses 206 206
Flags with carried forward coverage won't be shown. Click here to find out more.
|
f7749dc to
919d0ae
Compare
Also fix __annotations__ not working in Python 3.14 by using the annotation on the 'class' instead of on the 'instance' Closes: #3013
919d0ae to
642ea08
Compare
|
Well that was easy :) thanks @JohnVillalovos |
nejch
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix
__annotations__not working in Python 3.14 by using theannotation on the 'class' instead of on the 'instance'
Closes: #3013