fix normalization of `python_full_version` markers with pre-release versions #893

dimbleby · 2025-10-26T10:33:30Z

Replace the naive textual manipulation in create_nested_marker with direct manipulation of the objects, relying on their __str()__ implementation to be good.

To make sure that the text field is recalculated here, I made it an init=False field. That has the knock-on effect that we always normalize versions - which seems fine to me, probably a good thing.

There is one testcase in poetry proper that will need a one-character tweak to expect the newly normalized version number.

Added tests for changed code.
Updated documentation for changed code.

sourcery-ai · 2025-10-26T10:33:35Z

Reviewer's Guide

Replace manual text padding in nested marker creation with direct dataclass manipulation and rely on version str; make PEP440Version.text init=False to enforce normalization via to_string and remove parser text assignment; update tests to expect the new normalized version texts and adjusted markers.

Class diagram for updated PEP440Version and Release handling

classDiagram
    class PEP440Version {
        +Release release
        +ReleaseTag pre
        +ReleaseTag post
        +ReleaseTag dev
        +LocalSegmentType local
        -str text (init=False)
        -tuple _compare_key (init=False)
        +__post_init__()
        +to_string()
        +_make_compare_key()
    }
    class Release {
        +int major
        +int minor
        +int patch
    }
    PEP440Version --> Release : release
    PEP440Version --> ReleaseTag : pre
    PEP440Version --> ReleaseTag : post
    PEP440Version --> ReleaseTag : dev
    PEP440Version --> LocalSegmentType : local

Class diagram for create_nested_marker changes

classDiagram
    class create_nested_marker {
        +constraint
        +version
        +min_name
        +op
        +part
    }
    class Release {
        +major
        +minor
        +patch
    }
    class Version {
        +release
        +stable
        +__str__()
    }
    create_nested_marker --> Version : version
    Version --> Release : release

File-Level Changes

Change	Details	Files
Replace naive textual padding in nested marker creation with direct object manipulation and rely on str	use dataclasses.replace to pad missing release fields remove manual '.0' padding logic construct marker expression using version str	`src/poetry/core/packages/utils/utils.py`
Make version.text field init=False and always normalized	change text dataclass field to init=False in PEP440Version always set text via to_string() in post_init remove explicit text assignment in parser	`src/poetry/core/version/pep440/version.py` `src/poetry/core/version/pep440/parser.py`
Update tests to expect normalized version text and adjusted markers	add normalized parameter in test_parse_valid tweak expected text in test_version and test_parse_constraint update constraint tests to use new 'a1' and '.post' formats add new marker test for rc1 in utils tests	`tests/constraints/version/test_version.py` `tests/constraints/version/test_parse_constraint.py` `tests/packages/utils/test_utils.py`

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

sourcery-ai

Hey there - I've reviewed your changes and they look great!

Prompt for AI Agents

Please address the comments from this code review:

## Individual Comments

### Comment 1
<location> `tests/constraints/version/test_parse_constraint.py:456` </location>
<code_context>
+        ("^0-alpha.1", ">=0a1,<1"),
+        ("^0.1-alpha.1", ">=0.1a1,<0.2"),
+        ("^0.0.2-alpha.1", ">=0.0.2a1,<0.0.3"),
+        ("^0.1.2-alpha.1", ">=0.1.2a1,<0.2.0"),
         ("~1", ">=1,<2"),
         ("~1.0", ">=1.0,<1.1"),
</code_context>

<issue_to_address>
**suggestion (testing):** Missing test for normalization of post-release and dev-release constraints.

Please add tests for normalization of post-release (e.g., "1.0.0-post1") and dev-release (e.g., "1.0.0.dev1") constraints to cover these cases.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

for more information, see https://pre-commit.ci

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [poetry](https://github.com/python-poetry/poetry) ([changelog](https://python-poetry.org/history/)) | minor | ` 2.2.1` -> `2.3.0` | --- ### Release Notes <details> <summary>python-poetry/poetry (poetry)</summary> ### [`v2.3.0`](https://github.com/python-poetry/poetry/blob/HEAD/CHANGELOG.md#230---2026-01-18) [Compare Source](python-poetry/poetry@2.2.1...2.3.0) ##### Added - **Add support for exporting `pylock.toml` files with `poetry-plugin-export`** ([#10677](python-poetry/poetry#10677)). - Add support for specifying build constraints for dependencies ([#10388](python-poetry/poetry#10388)). - Add support for publishing artifacts whose version is determined dynamically by the build-backend ([#10644](python-poetry/poetry#10644)). - Add support for editable project plugins ([#10661](python-poetry/poetry#10661)). - Check `requires-poetry` before any other validation ([#10593](python-poetry/poetry#10593)). - Validate the content of `project.readme` when running `poetry check` ([#10604](python-poetry/poetry#10604)). - Add the option to clear all caches by making the cache name in `poetry cache clear` optional ([#10627](python-poetry/poetry#10627)). - Automatically update the cache for packages where the locked files differ from cached files ([#10657](python-poetry/poetry#10657)). - Suggest to clear the cache if running a command with `--no-cache` solves an issue ([#10585](python-poetry/poetry#10585)). - Propose `poetry init` when trying `poetry new` for an existing directory ([#10563](python-poetry/poetry#10563)). - Add support for `poetry publish --skip-existing` for new Nexus OSS versions ([#10603](python-poetry/poetry#10603)). - Show Poetry's own Python's path in `poetry debug info` ([#10588](python-poetry/poetry#10588)). ##### Changed - **Drop support for Python 3.9** ([#10634](python-poetry/poetry#10634)). - **Change the default of `installer.re-resolve` from `true` to `false`** ([#10622](python-poetry/poetry#10622)). - **PEP 735 dependency groups are considered in the lock file hash** ([#10621](python-poetry/poetry#10621)). - Deprecate `poetry.utils._compat.metadata`, which is sometimes used in plugins, in favor of `importlib.metadata` ([#10634](python-poetry/poetry#10634)). - Improve managing free-threaded Python versions with `poetry python` ([#10606](python-poetry/poetry#10606)). - Prefer JSON API to HTML API in legacy repositories ([#10672](python-poetry/poetry#10672)). - When running `poetry init`, only add the readme field in the `pyproject.toml` if the readme file exists ([#10679](python-poetry/poetry#10679)). - Raise an error if no hash can be determined for any distribution link of a package ([#10673](python-poetry/poetry#10673)). - Require `dulwich>=0.25.0` ([#10674](python-poetry/poetry#10674)). ##### Fixed - Fix an issue where `poetry remove` did not work for PEP 735 dependency groups with `include-group` items ([#10587](python-poetry/poetry#10587)). - Fix an issue where `poetry remove` caused dangling `include-group` references in PEP 735 dependency groups ([#10590](python-poetry/poetry#10590)). - Fix an issue where `poetry add` did not work for PEP 735 dependency groups with `include-group` items ([#10636](python-poetry/poetry#10636)). - Fix an issue where PEP 735 dependency groups were not considered in the lock file hash ([#10621](python-poetry/poetry#10621)). - Fix an issue where wrong markers were locked for a dependency that was required by several groups with different markers ([#10613](python-poetry/poetry#10613)). - Fix an issue where non-deterministic markers were created in a method used by `poetry-plugin-export` ([#10667](python-poetry/poetry#10667)). - Fix an issue where wrong wheels were chosen for installation in free-threaded Python environments if Poetry itself was not installed with free-threaded Python ([#10614](python-poetry/poetry#10614)). - Fix an issue where `poetry publish` used the metadata of the project instead of the metadata of the build artifact ([#10624](python-poetry/poetry#10624)). - Fix an issue where `poetry env use` just used another Python version instead of failing when the requested version was not supported by the project ([#10685](python-poetry/poetry#10685)). - Fix an issue where `poetry env activate` returned the wrong command for `dash` ([#10696](python-poetry/poetry#10696)). - Fix an issue where `data-dir` and `python.installation-dir` could not be set ([#10595](python-poetry/poetry#10595)). - Fix an issue where Python and pip executables were not correctly detected on Windows ([#10645](python-poetry/poetry#10645)). - Fix an issue where invalid template variables in `virtualenvs.prompt` caused an incomprehensible error message ([#10648](python-poetry/poetry#10648)). ##### Docs - Add a warning about `~/.netrc` for Poetry credential configuration ([#10630](python-poetry/poetry#10630)). - Clarify that the local configuration takes precedence over the global configuration ([#10676](python-poetry/poetry#10676)). - Add an explanation in which cases `packages` are automatically detected ([#10680](python-poetry/poetry#10680)). ##### poetry-core ([`2.3.0`](https://github.com/python-poetry/poetry-core/releases/tag/2.3.0)) - Normalize versions ([#893](python-poetry/poetry-core#893)). - Fix an issue where unsatisfiable requirements did not raise an error ([#891](python-poetry/poetry-core#891)). - Fix an issue where the implicit main group did not exist if it was explicitly declared as not having any dependencies ([#892](python-poetry/poetry-core#892)). - Fix an issue where `python_full_version` markers with pre-release versions were parsed incorrectly ([#893](python-poetry/poetry-core#893)). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.walbeck.it/walbeck-it/docker-python-poetry/pulls/1654 Co-authored-by: renovate-bot <[email protected]> Co-committed-by: renovate-bot <[email protected]>

sourcery-ai bot reviewed Oct 26, 2025

View reviewed changes

dimbleby force-pushed the fix-10599 branch from 06515e5 to 4ed8cfb Compare October 26, 2025 10:49

Spikhalskiy mentioned this pull request Oct 27, 2025

Update to v2.13.0 with poetry leads to "Invalid marker for 'python_full_version'" jlowin/fastmcp#2257

Closed

radoering mentioned this pull request Oct 31, 2025

tests: make test forward compatible with poetry-core#893 python-poetry/poetry#10605

Merged

radoering changed the title ~~fix poetry #10599~~ fix normalization of python_full_version markers with pre-release versions Oct 31, 2025

dimbleby and others added 2 commits October 31, 2025 06:15

fix poetry #10599

070fb73

[pre-commit.ci] auto fixes from pre-commit.com hooks

3df12ea

for more information, see https://pre-commit.ci

radoering force-pushed the fix-10599 branch from 52a5a69 to 3df12ea Compare October 31, 2025 05:15

radoering approved these changes Oct 31, 2025

View reviewed changes

radoering enabled auto-merge (squash) October 31, 2025 05:19

radoering merged commit acc1bc9 into python-poetry:main Oct 31, 2025
22 checks passed

dimbleby deleted the fix-10599 branch October 31, 2025 08:00

This was referenced Jan 17, 2026

relase: bump version to 2.3.0 #909

Merged

release: bump version to 2.3.0 python-poetry/poetry#10695

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix normalization of `python_full_version` markers with pre-release versions #893

fix normalization of `python_full_version` markers with pre-release versions #893

Uh oh!

dimbleby commented Oct 26, 2025 •

edited

Loading

Uh oh!

sourcery-ai bot commented Oct 26, 2025 •

edited

Loading

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

sourcery-ai bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix normalization of python_full_version markers with pre-release versions #893

fix normalization of python_full_version markers with pre-release versions #893

Uh oh!

Conversation

dimbleby commented Oct 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sourcery-ai bot commented Oct 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer's Guide

Class diagram for updated PEP440Version and Release handling

Class diagram for create_nested_marker changes

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix normalization of `python_full_version` markers with pre-release versions #893

fix normalization of `python_full_version` markers with pre-release versions #893

dimbleby commented Oct 26, 2025 •

edited

Loading

sourcery-ai bot commented Oct 26, 2025 •

edited

Loading