-
Notifications
You must be signed in to change notification settings - Fork 51
Update setup.py #331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update setup.py #331
Conversation
Small fix to enable vas_gssapi Signed-off-by: sanglist <[email protected]>
This pull request is stale because it has been open for 4 weeks with no activity. Remove stale label or comment or this will be closed in 2 weeks. |
Please merge to resolve setup issue |
@jborean93 this patch looks sane enough, ok if I merge it? |
Sorry this one was lost in my sea of notifications. At a glance it seems ok but I do wonder if it might potentially pick up some false positive match with some options where we may want to be a bit more selective for this particular scenario. |
Agreed but - it's a bug fix |
I only want to approve it when I know it won't break other use cases. What setup is causing the problem here is it a specific distro/package. What is the output of |
On SLES12 (SuSE 12 Enterprise) -Wl,-rpath,/opt/quest/lib64:/opt/quest/lib64/support -L/opt/quest/lib64 -lvas -L/opt/quest/lib64/support -lgcc_s -lvas-gssapi -lrt -lresolv |
Thanks, is |
It depends on corporate, right ? |
What I’m trying to get at is how can I test out this scenario. If I need to maintain this I need to know who could be affected and what scenarios this code needs to handle. Do you have any info on this vas-gssapi library. Is it a product I can install or is it a paid product. Are there docs online about it that you can share. |
The solution at: pykrb5/setup.py |
This pull request is stale because it has been open for 4 weeks with no activity. Remove stale label or comment or this will be closed in 2 weeks. |
Small fix to enable vas_gssapi
Signed-off-by: Shlomo Anglister [email protected]