Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update setup.py #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update setup.py #331

wants to merge 1 commit into from

Conversation

sanglist
Copy link

Small fix to enable vas_gssapi
Signed-off-by: Shlomo Anglister [email protected]

Small fix to enable vas_gssapi
Signed-off-by: sanglist <[email protected]>
Copy link

This pull request is stale because it has been open for 4 weeks with no activity. Remove stale label or comment or this will be closed in 2 weeks.

@github-actions github-actions bot added the stale label Nov 28, 2023
@sanglist
Copy link
Author

Please merge to resolve setup issue

@github-actions github-actions bot removed the stale label Nov 29, 2023
@simo5
Copy link
Contributor

simo5 commented Nov 29, 2023

@jborean93 this patch looks sane enough, ok if I merge it?

@jborean93
Copy link
Contributor

jborean93 commented Nov 29, 2023

Sorry this one was lost in my sea of notifications. At a glance it seems ok but I do wonder if it might potentially pick up some false positive match with some options where we may want to be a bit more selective for this particular scenario.

@sanglist
Copy link
Author

Sorry this one was lost in my sea of notifications. At a glance it seems ok but I do wonder if it might potentially pick up some false positive match with some options where we may want to be a bit more selective for this particular scenario.

Agreed but - it's a bug fix
Would appreciate you improving it.

@jborean93
Copy link
Contributor

jborean93 commented Nov 30, 2023

I only want to approve it when I know it won't break other use cases. What setup is causing the problem here is it a specific distro/package. What is the output of krb5-config --libs gssapi, is there potentially a better way of fixing your problem.

@sanglist
Copy link
Author

I only want to approve it when I know it won't break other use cases. What setup is causing the problem here, what is the output of krb5-config --libs gssapi and is there potentially a better way of fixing your problem.

On SLES12 (SuSE 12 Enterprise)

-Wl,-rpath,/opt/quest/lib64:/opt/quest/lib64/support -L/opt/quest/lib64 -lvas -L/opt/quest/lib64/support -lgcc_s -lvas-gssapi -lrt -lresolv

@jborean93
Copy link
Contributor

Thanks, is vas-gssapi just a SLES thing or is it a specific package here? I'm afraid I'm not familiar with it.

@sanglist
Copy link
Author

It depends on corporate, right ?
bridging all kinds of authentication protocols originating from a vast application space to corporate authentication.

@jborean93
Copy link
Contributor

What I’m trying to get at is how can I test out this scenario. If I need to maintain this I need to know who could be affected and what scenarios this code needs to handle. Do you have any info on this vas-gssapi library. Is it a product I can install or is it a paid product. Are there docs online about it that you can share.

@sanglist
Copy link
Author

The solution at: pykrb5/setup.py
Seems to provide a one size fits all using environment variables.

Copy link

This pull request is stale because it has been open for 4 weeks with no activity. Remove stale label or comment or this will be closed in 2 weeks.

@github-actions github-actions bot added the stale label Dec 29, 2023
@github-actions github-actions bot closed this Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants