Fix HHVM build for now again and ignore future HHVM build errors #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why not just remove it? |
|
@kelunik We want to be clear about what we communicate to people using our packages: HHVM is still supported by this package, it's just that Travis has changed their HHVM setup (once again) and only the test system setup fails. @WyriHaximus Have you tried upgrading the distro as per reactphp/socket#109? I would prefer giving this a try, if it doesn't work, I'm okay with just ignoring errors 👍 |
|
@clue trying that now 👍 |
jsor
approved these changes
Jul 3, 2017
This was referenced Aug 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently HHVM is failing, this PR allows HHVM to fail on Travis without failing the whole build