Use GitHub actions for continuous integration (CI) #442
Conversation
|
For the reference: The test run will only be triggered for any push or PR after this PR has been merged. This makes it a bit harder to review to see if the suggested workflow is actually successful. You can check the build status on my fork which executes the workflow from this PR branch: https://github.com/clue-labs/reactphp/tree/github-ci This is one time setup only, after this is merged, the build status will also show up in this repository. |
1e6c966 to
a99f4c1
Compare
Bye bye Travis CI, you've served us well.
@WyriHaximus Thanks for your suggestion! I agree this is an excellent suggestion and something that clearly demonstrates how GitHub actions are way more powerful than Travis has ever been! That being said, I have indeed evaluated this option after we've originally talked about this a few weeks back and think the current suggestion would be better suited for our use case. By relying on the automatic PHP version detection, a random PR that is opened some time in the future may fail because a new PHP version might have been tagged in the meantime. This means future PR reviews and development may be slowed down with something that's out of our control. Think awesome feature X in 1 year can not be merged because some obscure TLS error handling doesn't work as we're used to with a fresh PHP 8.1 release. Of course, we could get rid of the open ended PHP version constraint which we're currently using in all our components, but this comes with its own set of pros and cons, so this is something I would rather discuss in a separate ticket. I agree having to manually add future PHP versions to this list is not something that sounds like a very interesting task. I think this is however preferable because it's a) exactly what we did with Travis and known to be a reasonable amount of work and b) something that can easily be automated in the future (think a dedicated GitHub action that works kind of like dependabot?). Besides this suggestion, I've applied all other suggested changes 👍 My vote regarding automatic PHP versions would be to keep this as-is. We can always change this in the future as discussed above, so I don't think this should block the introduction of GitHub actions |
@clue The discussion about that doesn't block getting this in. Still think it is the better option, and possibly combined with scheduled runs we can mitigate that. But let's discuss that another time |
Bye bye Travis CI, you've served us well.
This changeset replaces the existing Travis CI integration with a new GitHub actions workflow. Travis CI has served us well for years, but is in the process of discontinuing its previous open source support. Right now, Travis CI builds may take anywhere from a few minutes to several hours.
The new GitHub actions workflow is designed to be as close as possible to the original definition, it does not introduce any new features. The GitHub actions workflow is significantly faster and uses higher concurrency, so it should take no longer than a couple of minutes to execute. Other than that, this switch should not have a noticeable impact on anybody contributing to this project.
I'm filing this PR here in the hope we can discuss this once and then later apply similar workflows for all our components. I've prepared PRs for this and will file these as soon as this one is merged.
Builds on top of #439 and clue/reactphp-flux#21