Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[fix search website] Changing the position of the script (not included) #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

s-pace
Copy link
Contributor

@s-pace s-pace commented Nov 7, 2018

#933 fixed
#932

cc @dbader

@dbader
Copy link
Member

dbader commented Nov 7, 2018

@s-pace Thanks, I guess we were a little too eager to get the previous PR merged :-) Seeing some JS console errors and the search box doesn't seem to work:

screenshot 2018-11-07 08 58 55

By the way, you can preview your changes by clicking the green checkmark next to each commit and clicking the "details" button next to the Netlify build step:

screenshot 2018-11-07 08 59 47

@kennethreitz
Copy link
Contributor

sorry about that!

@s-pace
Copy link
Contributor Author

s-pace commented Nov 7, 2018

Weird, I have created an input matching #q.

@dbader
Copy link
Member

dbader commented Nov 7, 2018

@s-pace Cool—can you change the placeholder on the search input to "Search the Guide"? Then we're ready to go I think!

@dbader
Copy link
Member

dbader commented Nov 7, 2018

And ideally the search input should take up 100% of the navbar width to match the rest of the content there.

@dbader
Copy link
Member

dbader commented Nov 7, 2018

Got some issue with the styles now:

screenshot 2018-11-07 09 17 04

@s-pace
Copy link
Contributor Author

s-pace commented Nov 7, 2018

I will inject the css in the same file.

@s-pace s-pace force-pushed the www/fix/search_script_position branch from 4da8230 to f526118 Compare November 7, 2018 17:25
@s-pace s-pace force-pushed the www/fix/search_script_position branch from 68f3702 to 18df25b Compare November 7, 2018 17:29
@s-pace
Copy link
Contributor Author

s-pace commented Nov 7, 2018

@dbader @kennethreitz

Ready to go

@kennethreitz kennethreitz merged commit 3fc0707 into realpython:master Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants